[nagios] review tests #1493
Merged
[nagios] review tests #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
| @@ -245,12 +244,15 @@ def _candidates_size_assert(self, candidates, count=None, at_least=1): | |||
| self.print_current_state() | |||
| raise | |||
|
|
|||
| def assertMetric(self, metric_name, value=None, tags=None, count=None, at_least=1): | |||
| def assertMetric(self, metric_name, value=None, tags=None, additional_attr=None, count=None, at_least=1): | |||
There was a problem hiding this comment.
I am not 100% convinced that we should add something as generic as that. We should just handle the device_name attribute through a named kwarg which seems reasonable because we do it exactly like the same way in the AgentCheck metrics submitting methods.
Also, it's still handled differently in the backend code.
yannmh
force-pushed
the
yann/nagios-review
branch
from
9d7d4a6 to
347af1f
Compare
|
Thanks for your feedback @LeoCavaille. I brought some changes to my PR. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.