[riak] add integration test #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
force-pushed
the
quentin/test_riak
branch
2 times, most recently
from
f53915f to
61b2634
Compare
53 tasks
degemer
force-pushed
the
quentin/test_riak
branch
from
61b2634 to
25df38f
Compare
| require './ci/common' | ||
|
|
||
| def riak_version | ||
| ENV['COUCHDB_VERSION'] || '2.0.5' |
There was a problem hiding this comment.
Just realize that I (again) left a bad c/p, will update after review.
degemer
force-pushed
the
quentin/test_riak
branch
2 times, most recently
from
993db2c to
036a03c
Compare
| for gauge in self.CHECK_GAUGES + self.CHECK_GAUGES_STATS: | ||
| self.assertMetric(gauge, count=1, tags=tags) | ||
|
|
||
| self.assertServiceCheckOK(self.check.SERVICE_CHECK_NAME, |
There was a problem hiding this comment.
You should explicitly write the service check name here so that the test fails if someone mistakenly changes it.
|
Also @degemer can you rebase, it's probably a simple |
degemer
force-pushed
the
quentin/test_riak
branch
from
036a03c to
9209362
Compare
|
Thanks @LeoCavaille ! Changes made, it should be ready. 💪 |
degemer
force-pushed
the
quentin/test_riak
branch
from
9209362 to
c7dbb7d
Compare
* build Riak from source (two riaks to be precise, to be able to build a cluster) * add custom tags to Riak check + usual pep8 * add a new test for Riak * do not run test on Travis if not able to use the cache And also: delete rotated log before caching
degemer
force-pushed
the
quentin/test_riak
branch
from
c7dbb7d to
a496053
Compare
|
nice, thanks 👍 |
LeoCavaille
added a commit
that referenced
this pull request
Apr 7, 2015
[riak] add integration test
|
Changes Unknown when pulling a496053 on quentin/test_riak into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster)
And also: delete rotated log before caching