Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] split tests/ into two subdirectories #1571

Merged
merged 2 commits into from
Apr 27, 2015

Conversation

degemer
Copy link
Member

@degemer degemer commented Apr 22, 2015

Separate agent core tests and all integration tests. I think it looks nicer and cleaner.

It's a WIP for now. I can't/don't want to run all tests locally, so I will fix them once they fail on Travis.

@remh
Copy link
Contributor

remh commented Apr 22, 2015

👍

@degemer degemer force-pushed the quentin/reorgnize-tests branch 7 times, most recently from 744dd7e to eccfcdd Compare April 22, 2015 23:17
@degemer
Copy link
Member Author

degemer commented Apr 23, 2015

Updated and ready, I added:

  • remove unused run_check in checks/init.py, which was importing
    from tests.common...
  • add a Resources class in tests.integrations.common to ease the use of
    fixtures

@degemer degemer force-pushed the quentin/reorgnize-tests branch 2 times, most recently from 7b744a4 to ee22a51 Compare April 23, 2015 17:22
@degemer degemer self-assigned this Apr 23, 2015
@degemer degemer force-pushed the quentin/reorgnize-tests branch 3 times, most recently from 7066888 to e25b78c Compare April 23, 2015 19:41
@degemer
Copy link
Member Author

degemer commented Apr 23, 2015

@degemer degemer removed their assignment Apr 23, 2015
@LeoCavaille
Copy link
Member

Nice! Just a nitpick, I am not a fan of the name Resources (I know I used it in ci/...) it's a bit confusing and it also refers to the processes snapshots used to create the memory treemaps.
Can we use stubs or fixtures maybe?

@degemer degemer force-pushed the quentin/reorgnize-tests branch from e25b78c to 0805d3c Compare April 27, 2015 16:01
degemer added 2 commits April 27, 2015 14:04
Separate agent core tests and all checks.d tests.
Even better, split checks tests into mocked tests and real integration
tests.
Also :
- remove unused `run_check` in checks/__init__.py, which was importing
  from tests.common...
- add a Fixtures class in tests.integrations.common to ease the use of
  fixtures
It displays the test coverage of `checks.d`, specifying if it's a mocked
test.
@degemer degemer force-pushed the quentin/reorgnize-tests branch from 0805d3c to 72be48e Compare April 27, 2015 18:05
@LeoCavaille
Copy link
Member

LGTM 👍

LeoCavaille added a commit that referenced this pull request Apr 27, 2015
[tests] split tests/ into two subdirectories
@LeoCavaille LeoCavaille merged commit 5f404d2 into master Apr 27, 2015
@LeoCavaille LeoCavaille deleted the quentin/reorgnize-tests branch April 27, 2015 19:40
@brettlangdon
Copy link
Member

#1427 and #1543 rebased and tests moved :)

@degemer
Copy link
Member Author

degemer commented May 8, 2015

Awesome, thanks @brettlangdon !

yannmh added a commit that referenced this pull request Jun 9, 2015
PR #1571 introduced a bad regression: 'run_check' method was deleted
beside it is still used on Windows to debug.
yannmh added a commit that referenced this pull request Jun 9, 2015
PR #1571 introduced a bad regression: 'run_check' method was deleted
beside it is still used on Windows to debug.
@coveralls
Copy link

coveralls commented Dec 16, 2016

Coverage Status

Changes Unknown when pulling 72be48e on quentin/reorgnize-tests into ** on master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants