-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mysql] Innodb status metrics (Percona) #1869
Conversation
by mysql check. The current set ofi MySQL metrics provided by Datadog is very limited (based on my experience as a Senior MySQL Consultant at Percona). The following changes have been made to the mysql check: a. Its heavily inspired by MySQL cacti template provided by Percona which contains an extensive set of checks that are important to measure the performance and health of a MySQL server. For reference please look at this URL: http://www.percona.com/doc/percona-monitoring-plugins/1.1/cacti/mysql-templates.html#sample-graphs b. Many of the important metrics exposed by Percona Server / MariaDB Server are not available in MySQL Server as status variables, these have been added by parsing the output of "SHOW ENGINE INNODB STATUS" Collect Binary log stats only when binlogging is enabled mysql.net.max_connections_available was improperly set to be a RATE instead of a GAUGE The metric mysql.innodb.row_lock_waits was incorrectly being sent as GAUGE while its a RATE Float values in InnoDB status were not being parsed correctly
… parsing for Percona metrics
44c12e7
to
882017a
Compare
@ovaistariq I'm going to assign a new reviewer to work on this one and expect to release it with our 5.7.0 release. In the meantime you can use this check as a custom check. |
@remh thanks for the update. I am already using it as a custom check. But would love to see it released soon as a standard check. |
@remh Would this be released with a Datadog agent release before April 2016? I was hoping to do a talk around Datadog monitoring for MySQL at Percona Conference in 2016 (which is the biggest annual MySQL conference). |
@ovaistariq We expect a few agent releases before then. If you drop me a line via email ilan@datadoghq.com we'd be happy to collaborate or support you regarding the session. |
FYI the new test failures look to be flake8 related. ./checks.d/mongo.py:476:25: F821 undefined name 'types' |
@irabinovitch I have sent you an email, thanks. |
There are some really neat metrics being collected that we would love to take advantage of. Thought I'd bump this convo and maybe get an ETA? Thanks! |
@MiguelMoll We are working towards inclusion in our 5.7 agent release which is the next major release. |
@truthbk @garnermccloud can we close this in favor of #2116 which is slated for 5.7? |
Parse Innodb Status to get Percona Style metrics
Cleaned up, rebased and added testing to #1269
Fixes #152 and #685