integration(kong) Added Kong checks #2241

shashiranjan84 · 2016-02-02T03:56:31Z

Kong is an open-source management layer for API. More details about Kong can be found at https://getkong.org/

JohnLZeller · 2016-02-05T16:36:48Z

Hey @shashiranjan84, thanks for the PR!
We'll take a deeper look at this soon.

irabinovitch · 2016-02-05T20:17:06Z

@shashiranjan84 Thank you for this check and the corresponding integration template. Our team is reviewing and will be back in touch with next steps.

shashiranjan84 · 2016-02-05T20:18:22Z

Great, thanks.
On Feb 5, 2016 12:17 PM, "Ilan Rabinovitch" notifications@github.com
wrote:

@shashiranjan84 https://github.com/shashiranjan84 Thank you for this
check and the corresponding integration template. Our team is reviewing and
will be back in touch with next steps.

—
Reply to this email directly or view it on GitHub
#2241 (comment).

shashiranjan84 · 2016-02-16T18:21:03Z

Any idea when it would be merged and released?

sonicaghi · 2016-02-16T23:01:33Z

+1

irabinovitch · 2016-03-04T08:47:31Z

@shashiranjan84 We merge PRs as we approach a release. At the moment this has the 5.8 label on it.

shashiranjan84 · 2016-04-30T17:39:55Z

@JohnLZeller @irabinovitch any update on the release date of version 5.8

degemer · 2016-05-09T21:27:45Z

checks.d/kong.py

+                name, value, tags = row
+                self.gauge(name, value, tags)
+            except Exception:
+                self.log.error(u'Could not submit metric: %s' % repr(row))


Could you do something like this instead : self.log.error(u'Could not submit metric: %s', row) ? Because of https://www.simonmweber.com/2014/11/24/python-logging-traps.html

degemer · 2016-05-09T21:53:31Z

Thanks for your contribution @shashiranjan84 !

I added a few comments, it looks good otherwise (really nice setup for the integration tests).
Once they are addressed, we should be good to merge.

Let me know if you need more information !

shashiranjan84 · 2016-05-09T22:33:11Z

@degemer thanks, updated the code as you advised. Please review.

shashiranjan84 · 2016-05-09T22:39:14Z

too early, still need to update the test.

shashiranjan84 · 2016-05-10T00:32:12Z

@degemer I want to update Kong version in the Integration test, so checking if I have some time before next release. I am aiming to finish by tomorrow evening.

degemer · 2016-05-10T14:19:09Z

@shashiranjan84 Yes, today or tomorrow is fine.

About the errors of the CI, the first one is a simple style issue on your Ruby code (https://travis-ci.org/DataDog/dd-agent/jobs/129063985#L319), and the other one is a metrics coverage issue. To fix it, it would be perfect if you could check the presence of all expected metrics and service checks. It's then way easier for us to test the new Kong versions.

The other changes look good !

shashiranjan84 · 2016-05-10T22:29:28Z

@degemer Please have a look, updated Kong version and test as you advised.

degemer · 2016-05-11T15:52:27Z

checks.d/kong.py

+
+        parsed_url = urlparse.urlparse(url)
+        host = parsed_url.hostname
+        port = parsed_url.port or 8001


Shouldn't the default port be 80 in this case ?

Kong default admin port is 8001.

Indeed, but if a URL is provided without a specific port, wouldn't requests try the port 80 ? (Since this port is taken from the kong_status_url which is queried afterwards)

should be the parsed_url.port would be null in that case and port will be defaulted 8001?

I'm not sure I understand what you mean.
I think there are two cases :

kong_status_url: http://something:port/status, and parsed_url.port returns port as expected.

kong_status_url: http://something/status, and parsed_url.port returns None, and there is (I think) a small issue, because the current check tags with kong_port: 8001 whereas response = requests.get(url, headers=headers(self.agentConfig)) tries to connect on the port 80 (default HTTP port), contradicting the tag.

If you want to have a default for the kong_port, you could instead of asking for an URL in the config file (kong.yaml.example) ask for a port(set a default to 8001) and a host and then build the URL in the check url = 'http://{}:{}/status'.format(host, port).
It would only be possible if the URL is always the same (the /status part).

It's really a nitpick (I guess every user of the check will specify the port), but please let me know what you think about it.

You are right it will fail while making the request. I have removed the default port and expecting user to always provide the correct kong status url.

degemer · 2016-05-11T16:00:51Z

Thank you ! I tested one last time and noticed two small issues, could you fix them ?

shashiranjan84 · 2016-05-11T16:38:44Z

@degemer thanks, please review changes.

Kong is an open-source management layer for API. More details about Kong can be found at website:https://getkong.org/ github:https://github.com/Mashape/kong

degemer · 2016-05-11T18:29:58Z

Merged as 436d0fb.
Thanks again for your contribution and your reactivity !

shashiranjan84 · 2016-05-11T19:13:49Z

Thank you all your help @dspangen. I have also sent PR for IntegrationTemplate. Please review that too

DataDog/IntegrationTemplate#11

degemer · 2016-05-11T21:59:07Z

@shashiranjan84 Sure, I'll take have a look tomorrow.

irabinovitch · 2016-05-12T17:46:09Z

@shashiranjan84 we're all set on the integration template. Once the 5.8 agent is released we'll be able to publish the tile and close out that PR.

sonicaghi · 2016-05-19T06:17:16Z

@irabinovitch do you know when the 5.8 is going out?

irabinovitch · 2016-05-23T16:10:46Z

This week.

shashiranjan84 force-pushed the master branch from 2bca723 to 47a0007 Compare February 2, 2016 20:37

JohnLZeller added this to the Triage milestone Feb 5, 2016

JohnLZeller added checks new integration community labels Feb 5, 2016

remh modified the milestones: 5.8.0, Triage, Integration SDK - New Integrations Feb 8, 2016

degemer self-assigned this May 9, 2016

degemer reviewed May 9, 2016
View reviewed changes

shashiranjan84 force-pushed the master branch 2 times, most recently from 4b5979d to 158b142 Compare May 9, 2016 22:31

shashiranjan84 force-pushed the master branch 2 times, most recently from 80ef990 to f5431d6 Compare May 10, 2016 00:23

shashiranjan84 force-pushed the master branch from f5431d6 to bcdf380 Compare May 10, 2016 00:49

shashiranjan84 force-pushed the master branch 6 times, most recently from dbbe42c to d6bd151 Compare May 10, 2016 07:44

shashiranjan84 force-pushed the master branch 6 times, most recently from 59060e4 to 3d4944a Compare May 10, 2016 21:35

shashiranjan84 force-pushed the master branch from 3d4944a to ae295cd Compare May 11, 2016 01:27

degemer reviewed May 11, 2016
View reviewed changes

shashiranjan84 force-pushed the master branch from ae295cd to f150ac0 Compare May 11, 2016 16:36

integration(kong) Added Kong checks

648272b

Kong is an open-source management layer for API. More details about Kong can be found at website:https://getkong.org/ github:https://github.com/Mashape/kong

shashiranjan84 force-pushed the master branch from f150ac0 to 648272b Compare May 11, 2016 18:05

degemer closed this May 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integration(kong) Added Kong checks #2241

integration(kong) Added Kong checks #2241

shashiranjan84 commented Feb 2, 2016

JohnLZeller commented Feb 5, 2016

irabinovitch commented Feb 5, 2016

shashiranjan84 commented Feb 5, 2016

shashiranjan84 commented Feb 16, 2016

sonicaghi commented Feb 16, 2016

irabinovitch commented Mar 4, 2016

shashiranjan84 commented Apr 30, 2016

degemer May 9, 2016

degemer commented May 9, 2016

shashiranjan84 commented May 9, 2016

shashiranjan84 commented May 9, 2016

shashiranjan84 commented May 10, 2016

degemer commented May 10, 2016

shashiranjan84 commented May 10, 2016

degemer May 11, 2016

shashiranjan84 May 11, 2016

degemer May 11, 2016

shashiranjan84 May 11, 2016

degemer May 11, 2016

shashiranjan84 May 11, 2016 •

edited

Loading

degemer commented May 11, 2016

shashiranjan84 commented May 11, 2016

degemer commented May 11, 2016

shashiranjan84 commented May 11, 2016

degemer commented May 11, 2016

irabinovitch commented May 12, 2016

sonicaghi commented May 19, 2016

irabinovitch commented May 23, 2016

integration(kong) Added Kong checks #2241

integration(kong) Added Kong checks #2241

Conversation

shashiranjan84 commented Feb 2, 2016

JohnLZeller commented Feb 5, 2016

irabinovitch commented Feb 5, 2016

shashiranjan84 commented Feb 5, 2016

shashiranjan84 commented Feb 16, 2016

sonicaghi commented Feb 16, 2016

irabinovitch commented Mar 4, 2016

shashiranjan84 commented Apr 30, 2016

degemer May 9, 2016

Choose a reason for hiding this comment

degemer commented May 9, 2016

shashiranjan84 commented May 9, 2016

shashiranjan84 commented May 9, 2016

shashiranjan84 commented May 10, 2016

degemer commented May 10, 2016

shashiranjan84 commented May 10, 2016

degemer May 11, 2016

Choose a reason for hiding this comment

shashiranjan84 May 11, 2016

Choose a reason for hiding this comment

degemer May 11, 2016

Choose a reason for hiding this comment

shashiranjan84 May 11, 2016

Choose a reason for hiding this comment

degemer May 11, 2016

Choose a reason for hiding this comment

shashiranjan84 May 11, 2016 • edited Loading

Choose a reason for hiding this comment

degemer commented May 11, 2016

shashiranjan84 commented May 11, 2016

degemer commented May 11, 2016

shashiranjan84 commented May 11, 2016

degemer commented May 11, 2016

irabinovitch commented May 12, 2016

sonicaghi commented May 19, 2016

irabinovitch commented May 23, 2016

shashiranjan84 May 11, 2016 •

edited

Loading