Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark] Replace all histograms by counters #2479

Merged
merged 1 commit into from
May 9, 2016
Merged

[spark] Replace all histograms by counters #2479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 40 additions & 44 deletions checks.d/spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
SPARK_SERVICE_CHECK = 'spark.application_master.can_connect'

# URL Paths
INFO_PATH = 'ws/v1/cluster/info'
YARN_APPS_PATH = 'ws/v1/cluster/apps'
SPARK_APPS_PATH = 'api/v1/applications'

Expand All @@ -95,37 +94,36 @@
YARN_APPLICATION_STATES = 'RUNNING'

# Metric types
HISTOGRAM = 'histogram'
INCREMENT = 'increment'

# Metrics to collect
SPARK_JOB_METRICS = {
'numTasks': ('spark.job.num_tasks', HISTOGRAM),
'numActiveTasks': ('spark.job.num_active_tasks', HISTOGRAM),
'numCompletedTasks': ('spark.job.num_completed_tasks', HISTOGRAM),
'numSkippedTasks': ('spark.job.num_skipped_tasks', HISTOGRAM),
'numFailedTasks': ('spark.job.num_failed_tasks', HISTOGRAM),
'numActiveStages': ('spark.job.num_active_stages', HISTOGRAM),
'numCompletedStages': ('spark.job.num_completed_stages', HISTOGRAM),
'numSkippedStages': ('spark.job.num_skipped_stages', HISTOGRAM),
'numFailedStages': ('spark.job.num_failed_stages', HISTOGRAM)
'numTasks': ('spark.job.num_tasks', INCREMENT),
'numActiveTasks': ('spark.job.num_active_tasks', INCREMENT),
'numCompletedTasks': ('spark.job.num_completed_tasks', INCREMENT),
'numSkippedTasks': ('spark.job.num_skipped_tasks', INCREMENT),
'numFailedTasks': ('spark.job.num_failed_tasks', INCREMENT),
'numActiveStages': ('spark.job.num_active_stages', INCREMENT),
'numCompletedStages': ('spark.job.num_completed_stages', INCREMENT),
'numSkippedStages': ('spark.job.num_skipped_stages', INCREMENT),
'numFailedStages': ('spark.job.num_failed_stages', INCREMENT)
}

SPARK_STAGE_METRICS = {
'numActiveTasks': ('spark.stage.num_active_tasks', HISTOGRAM),
'numCompleteTasks': ('spark.stage.num_complete_tasks', HISTOGRAM),
'numFailedTasks': ('spark.stage.num_failed_tasks', HISTOGRAM),
'executorRunTime': ('spark.stage.executor_run_time', HISTOGRAM),
'inputBytes': ('spark.stage.input_bytes', HISTOGRAM),
'inputRecords': ('spark.stage.input_records', HISTOGRAM),
'outputBytes': ('spark.stage.output_bytes', HISTOGRAM),
'outputRecords': ('spark.stage.output_records', HISTOGRAM),
'shuffleReadBytes': ('spark.stage.shuffle_read_bytes', HISTOGRAM),
'shuffleReadRecords': ('spark.stage.shuffle_read_records', HISTOGRAM),
'shuffleWriteBytes': ('spark.stage.shuffle_write_bytes', HISTOGRAM),
'shuffleWriteRecords': ('spark.stage.shuffle_write_records', HISTOGRAM),
'memoryBytesSpilled': ('spark.stage.memory_bytes_spilled', HISTOGRAM),
'diskBytesSpilled': ('spark.stage.disk_bytes_spilled', HISTOGRAM)
'numActiveTasks': ('spark.stage.num_active_tasks', INCREMENT),
'numCompleteTasks': ('spark.stage.num_complete_tasks', INCREMENT),
'numFailedTasks': ('spark.stage.num_failed_tasks', INCREMENT),
'executorRunTime': ('spark.stage.executor_run_time', INCREMENT),
'inputBytes': ('spark.stage.input_bytes', INCREMENT),
'inputRecords': ('spark.stage.input_records', INCREMENT),
'outputBytes': ('spark.stage.output_bytes', INCREMENT),
'outputRecords': ('spark.stage.output_records', INCREMENT),
'shuffleReadBytes': ('spark.stage.shuffle_read_bytes', INCREMENT),
'shuffleReadRecords': ('spark.stage.shuffle_read_records', INCREMENT),
'shuffleWriteBytes': ('spark.stage.shuffle_write_bytes', INCREMENT),
'shuffleWriteRecords': ('spark.stage.shuffle_write_records', INCREMENT),
'memoryBytesSpilled': ('spark.stage.memory_bytes_spilled', INCREMENT),
'diskBytesSpilled': ('spark.stage.disk_bytes_spilled', INCREMENT)
}

SPARK_DRIVER_METRICS = {
Expand All @@ -144,25 +142,25 @@
}

SPARK_EXECUTOR_METRICS = {
'rddBlocks': ('spark.executor.rdd_blocks', HISTOGRAM),
'memoryUsed': ('spark.executor.memory_used', HISTOGRAM),
'diskUsed': ('spark.executor.disk_used', HISTOGRAM),
'activeTasks': ('spark.executor.active_tasks', HISTOGRAM),
'failedTasks': ('spark.executor.failed_tasks', HISTOGRAM),
'completedTasks': ('spark.executor.completed_tasks', HISTOGRAM),
'totalTasks': ('spark.executor.total_tasks', HISTOGRAM),
'totalDuration': ('spark.executor.total_duration', HISTOGRAM),
'totalInputBytes': ('spark.executor.total_input_bytes', HISTOGRAM),
'totalShuffleRead': ('spark.executor.total_shuffle_read', HISTOGRAM),
'totalShuffleWrite': ('spark.executor.total_shuffle_write', HISTOGRAM),
'maxMemory': ('spark.executor.max_memory', HISTOGRAM)
'rddBlocks': ('spark.executor.rdd_blocks', INCREMENT),
'memoryUsed': ('spark.executor.memory_used', INCREMENT),
'diskUsed': ('spark.executor.disk_used', INCREMENT),
'activeTasks': ('spark.executor.active_tasks', INCREMENT),
'failedTasks': ('spark.executor.failed_tasks', INCREMENT),
'completedTasks': ('spark.executor.completed_tasks', INCREMENT),
'totalTasks': ('spark.executor.total_tasks', INCREMENT),
'totalDuration': ('spark.executor.total_duration', INCREMENT),
'totalInputBytes': ('spark.executor.total_input_bytes', INCREMENT),
'totalShuffleRead': ('spark.executor.total_shuffle_read', INCREMENT),
'totalShuffleWrite': ('spark.executor.total_shuffle_write', INCREMENT),
'maxMemory': ('spark.executor.max_memory', INCREMENT)
}

SPARK_RDD_METRICS = {
'numPartitions': ('spark.rdd.num_partitions', HISTOGRAM),
'numCachedPartitions': ('spark.rdd.num_cached_partitions', HISTOGRAM),
'memoryUsed': ('spark.rdd.memory_used', HISTOGRAM),
'diskUsed': ('spark.rdd.disk_used', HISTOGRAM)
'numPartitions': ('spark.rdd.num_partitions', INCREMENT),
'numCachedPartitions': ('spark.rdd.num_cached_partitions', INCREMENT),
'memoryUsed': ('spark.rdd.memory_used', INCREMENT),
'diskUsed': ('spark.rdd.disk_used', INCREMENT)
}


Expand Down Expand Up @@ -366,9 +364,7 @@ def _set_metric(self, metric_name, metric_type, value, tags=None):
'''
Set a metric
'''
if metric_type == HISTOGRAM:
self.histogram(metric_name, value, tags=tags)
elif metric_type == INCREMENT:
if metric_type == INCREMENT:
self.increment(metric_name, value, tags=tags)
else:
self.log.error('Metric type "%s" unknown' % (metric_type))
Expand Down
5 changes: 0 additions & 5 deletions tests/checks/fixtures/spark/cluster_info
View file
Open in desktop

This file was deleted.

94 changes: 47 additions & 47 deletions tests/checks/fixtures/spark/stage_metrics
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,20 @@
"status": "COMPLETE",
"stageId": 0,
"attemptId": 0,
"numActiveTasks": 0,
"numCompleteTasks": 0,
"numFailedTasks": 0,
"executorRunTime": 0,
"inputBytes": 0,
"inputRecords": 0,
"outputBytes": 0,
"outputRecords": 0,
"shuffleReadBytes": 0,
"shuffleReadRecords": 0,
"shuffleWriteBytes": 0,
"shuffleWriteRecords": 0,
"memoryBytesSpilled": 0,
"diskBytesSpilled": 0,
"numActiveTasks": 100,
"numCompleteTasks": 101,
"numFailedTasks": 102,
"executorRunTime": 103,
"inputBytes": 104,
"inputRecords": 105,
"outputBytes": 106,
"outputRecords": 107,
"shuffleReadBytes": 108,
"shuffleReadRecords": 109,
"shuffleWriteBytes": 110,
"shuffleWriteRecords": 111,
"memoryBytesSpilled": 112,
"diskBytesSpilled": 113,
"name": "reduceByKey at <stdin>:1",
"details": "",
"schedulingPool": "default",
Expand Down Expand Up @@ -70,48 +70,48 @@
},
{
"status": "RUNNING",
"stageId": 0,
"attemptId": 0,
"numActiveTasks": 0,
"numCompleteTasks": 0,
"numFailedTasks": 0,
"executorRunTime": 0,
"inputBytes": 0,
"inputRecords": 0,
"outputBytes": 0,
"outputRecords": 0,
"shuffleReadBytes": 0,
"shuffleReadRecords": 0,
"shuffleWriteBytes": 0,
"shuffleWriteRecords": 0,
"memoryBytesSpilled": 0,
"diskBytesSpilled": 0,
"stageId": 1,
"attemptId": 2,
"numActiveTasks": 3,
"numCompleteTasks": 4,
"numFailedTasks": 5,
"executorRunTime": 6,
"inputBytes": 7,
"inputRecords": 8,
"outputBytes": 9,
"outputRecords": 10,
"shuffleReadBytes": 11,
"shuffleReadRecords": 12,
"shuffleWriteBytes": 13,
"shuffleWriteRecords": 14,
"memoryBytesSpilled": 15,
"diskBytesSpilled": 16,
"name": "reduceByKey at <stdin>:1",
"details": "",
"schedulingPool": "default",
"accumulatorUpdates": []
},
{
"status": "RUNNING",
"stageId": 0,
"attemptId": 0,
"numActiveTasks": 0,
"numCompleteTasks": 0,
"numFailedTasks": 0,
"executorRunTime": 0,
"inputBytes": 0,
"inputRecords": 0,
"outputBytes": 0,
"outputRecords": 0,
"shuffleReadBytes": 0,
"shuffleReadRecords": 0,
"shuffleWriteBytes": 0,
"shuffleWriteRecords": 0,
"memoryBytesSpilled": 0,
"diskBytesSpilled": 0,
"stageId": 1,
"attemptId": 2,
"numActiveTasks": 3,
"numCompleteTasks": 4,
"numFailedTasks": 5,
"executorRunTime": 6,
"inputBytes": 7,
"inputRecords": 8,
"outputBytes": 9,
"outputRecords": 10,
"shuffleReadBytes": 11,
"shuffleReadRecords": 12,
"shuffleWriteBytes": 13,
"shuffleWriteRecords": 14,
"memoryBytesSpilled": 15,
"diskBytesSpilled": 16,
"name": "reduceByKey at <stdin>:1",
"details": "",
"schedulingPool": "default",
"accumulatorUpdates": []
}
]
]
Loading