[Postgres] hard limit on pg count metric #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
force-pushed
the
massi/configure_postgres_count_metrics
branch
from
15ccbef to
c06420b
Compare
masci
changed the title
|
👍 |
degemer
added a commit
that referenced
this pull request
Jun 7, 2016
* master: (21 commits) [Postgres] hard limit on pg count metric (#2575) [procfs] make /proc configurable. [sqlserver] send service checks at every run (#2515) [http_check] SNI support for cert_expiration (#2521) [dev-env] DL ez_setup from preferred URL Example syntax using a wildcard, recommended by customer see ticket https://datadog.zendesk.com/agent/tickets/54475 [collector] don't send the api_key with resources [checks] remove api_key from events payload [packaging] 5.9.0 nightlies [win32] plays well memory check timeouts [rabbitmq] Avoid the extra double lookup for 'rabbitmq_api_url' (#2543) [source] archive setuptools Added a note on how to get bundler installed [kubernetes] disable use_histogram by default (#2542) [powerdns_recursor] rename configuration file (#2538) [changelog] release 5.8.2 Revert "Fix get_hostname for windows ec2 instances" [changelog] release `5.8.1` fixes .yaml.default [core] fixes windows conf (#2528) ...
gmmeyer
pushed a commit
that referenced
this pull request
Jun 17, 2016
* hard limit on pg count metric * order by schemaname,relname to handle tables homonimy across schemas
gmmeyer
pushed a commit
that referenced
this pull request
Jun 17, 2016
* hard limit on pg count metric * order by schemaname,relname to handle tables homonimy across schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counting the number of tables to provide the
postgresql.table.countmetric can be very expensive, especially on large clusters.This PR contains two changes to mitigate the impact of a slow count:
postgres.yamlfileFor backward compatibility, the metric is still collected by default
Notice: couldn't provide an integration test for the hard limit feature because the strings containing the SQL code are class fields evaluated at import time.