Monotonic rate counters (#23) #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Do you know what happens when UnknownValue bubbles up? We obviously don't want the agent to crash when one counter wraps. |
|
Agent calls either get_samples_with_timestamps or get_samples which are catching all exceptions and just not dumping the problematic value (mongo is using get_sample but is catching UnknownValue explicitly) |
alq666
added a commit
that referenced
this pull request
Apr 19, 2012
Fixes Monotonic rate counters (#23)
|
Initially defined in #23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we are not reporting metric on a wrapped counter. This works only for increasing counters (not decreasing). An 'UnknownValue' exception is raised if the counter is decreasing, allowing the value not to be picked up at all by the agent.
Updated tests to reflect the change.