Lighttpd Check #385
Merged
Lighttpd Check #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For #384 |
|
|
||
| def check(self, instance): | ||
| if 'lighttpd_status_url' not in instance: | ||
| self.log.warn("Missing 'lighttpd_status_url' in Lighttpd config") |
There was a problem hiding this comment.
We should raise an exception instead. So that it would appear in the info page.
There was a problem hiding this comment.
Cool, good idea. It should do this for apache then too.
|
Looks good! nice fast job ! |
|
while you're up in here ... thoughts on this? |
|
PS 👍 |
|
Looks good, merging it. |
|
This check won't let users know if they haven't configured the check properly (e.g. wrong url). Can we fix this before releasing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly the same as the apache check.