Explicit per-table PG stats #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-table-stats Conflicts: checks.d/postgres.py
ghost
assigned 
| packaging/root/ | ||
| /.vagrant/machines/default/virtualbox/id |
There was a problem hiding this comment.
This can be /.vagrant/ alone, we don't want anything from that subdir in git.
Conflicts: checks.d/postgres.py
|
|
||
| # Do we need relation-specific metrics? | ||
| if relations is None or relations == []: |
There was a problem hiding this comment.
nitpick but you can just do:
if not relations:here
There was a problem hiding this comment.
Oh I miss string[] in the function signature...
|
@alq666 What's the overall status ? |
No need for a __main__ section.
Conflicts: checks.d/postgres.py
|
@remh should be good to go for a merge. I will add more stats in a later version. |
|
@alq666 Can you merge back the master branch into your branch and fix the conflicts ? |
… pg-per-table-stats # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@remh this is for 4.1. I see this is new beginnings more than a definitive PG check.
I have spent some time reworking the check to make the collection of per-table stats easier. There are now up to 3 statistics queries executed: one for all databases, one for all listed tables (or relations in pg parlance) and one for all indices of the listed tables.
Tagging is per database, per table.
There is a number of other metrics we can get. It should be relatively easy to add without altering the structure of the check (in particular the collect_stats part that parses results).
The table list is made explicit to not generate boat loads of useless metrics.
@clofresh probably of interest to you too.