-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bind_host parameter to support Openshift integration (localhost can't be used) #875
Conversation
Is it because the gears are IPv6 only? |
Actually no, I saw that they were not this morning. |
You can't use 'localhost' on a gear, you actually need to bind the internal IP which starts with 127.xxx. That was the source of my errors... |
--system-site-packages param
@qqfr2507 do you need anyone to review? |
Yes, I don't know if @remh had time to have a look at it yet. |
Looks good to me. @remh should we wait until you cut the 4.2 release? |
@qqfr2507 does this still need to be merged for openshift to work? |
No, it can work without the merge (because I copied the agent installation Quentin On Sun, Apr 6, 2014 at 11:55 PM, Alexis Lê-Quôc notifications@github.comwrote:
|
@@ -3,6 +3,9 @@ | |||
# The host of the Datadog intake server to send Agent data to | |||
dd_url: https://app.datadoghq.com | |||
|
|||
# The loopback address the Agent will bind | |||
bind_host: localhost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment that line so it reflects that this parameter is optional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@remh Here are the modifications I made to be able to configure a custom loopback address. I tested it with Openshift, it seems to work. Any feedback on your side?