RUM-3460: Fix padding and resizing issue for image view mapper

DataDog · Nov 5, 2024 · 95ab882 · 95ab882
1 parent b1d6ebb
commit 95ab882
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/.../datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelper.kt b/.../datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelper.kt
@@ -7,7 +7,6 @@
 package com.datadog.android.sessionreplay.internal.recorder.resources
 
 import android.graphics.drawable.Drawable
-import android.graphics.drawable.GradientDrawable
 import android.graphics.drawable.InsetDrawable
 import android.graphics.drawable.LayerDrawable
 import android.view.View
@@ -238,7 +237,6 @@ internal class DefaultImageWireframeHelper(
                 }
             }
 
-            is GradientDrawable -> DrawableProperties(drawable, view.width, view.height)
             else -> DrawableProperties(drawable, width, height)
         }
     }

diff --git a/...replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/utils/ImageViewUtils.kt b/...replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/utils/ImageViewUtils.kt
@@ -19,12 +19,15 @@ internal object ImageViewUtils {
         // this will always have size >= 2
         @Suppress("UnsafeThirdPartyFunctionCall")
         view.getLocationOnScreen(coords)
-
+        val leftPadding = view.paddingLeft
+        val rightPadding = view.paddingRight
+        val topPadding = view.paddingTop
+        val bottomPadding = view.paddingBottom
         return Rect(
-            coords[0],
-            coords[1],
-            coords[0] + view.width,
-            coords[1] + view.height
+            coords[0] + leftPadding,
+            coords[1] + topPadding,
+            coords[0] + view.width - rightPadding,
+            coords[1] + view.height - bottomPadding
         )
     }
 

diff --git a/sample/kotlin/src/main/res/layout/fragment_image_components.xml b/sample/kotlin/src/main/res/layout/fragment_image_components.xml
@@ -339,7 +339,8 @@
                 <ImageView
                     android:id="@+id/imageView_remote"
                     android:layout_width="160dp"
-                    android:layout_height="wrap_content"
+                    android:layout_height="160dp"
+                    android:padding="32dp"
                     android:scaleType="fitCenter"
                     android:contentDescription="@null"
                     android:layout_marginEnd="8dp"