Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up benchmark tool and application code #2184

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

Clean up the code according to the PR reviews

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners August 13, 2024 07:57
@ambushwork ambushwork force-pushed the yl/metric-benchmark-fix branch from d3df1ad to c349c5e Compare August 13, 2024 08:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (27f8ab9) to head (c349c5e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2184      +/-   ##
===========================================
+ Coverage    69.96%   70.05%   +0.08%     
===========================================
  Files          726      726              
  Lines        26978    26981       +3     
  Branches      4524     4520       -4     
===========================================
+ Hits         18875    18900      +25     
+ Misses        6831     6824       -7     
+ Partials      1272     1257      -15     

see 36 files with indirect coverage changes

@ambushwork ambushwork merged commit 2ea9e5e into develop Aug 13, 2024
22 checks passed
@ambushwork ambushwork deleted the yl/metric-benchmark-fix branch August 13, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants