Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.9 and AGP to 8.5.2 #2192

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Aug 13, 2024

What does this PR do?

Since we are now using Kotlin 1.9, we can also update Gradle and AGP to the newer versions (which were bringing Kotlin 1.9 to the classpath).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm force-pushed the nogorodnikov/gradle-8.9-agp-8.5.2 branch from b8d58e9 to 3269ee1 Compare August 13, 2024 14:50
@0xnm 0xnm force-pushed the nogorodnikov/gradle-8.9-agp-8.5.2 branch from 3269ee1 to c07bc24 Compare August 13, 2024 15:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.99%. Comparing base (6d2cf93) to head (c07bc24).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2192      +/-   ##
===========================================
- Coverage    70.02%   69.99%   -0.02%     
===========================================
  Files          726      726              
  Lines        27004    26968      -36     
  Branches      4526     4522       -4     
===========================================
- Hits         18907    18876      -31     
+ Misses        6827     6826       -1     
+ Partials      1270     1266       -4     
Files Coverage Δ
...compat/widget/DatadogActionBarContainerAccessor.kt 100.00% <100.00%> (ø)
...ternal/recorder/mapper/ActionBarContainerMapper.kt 90.48% <ø> (ø)
...main/java/com/datadog/exec/CommonTaskExecutor.java 47.83% <100.00%> (ø)

... and 26 files with indirect coverage changes

@0xnm 0xnm marked this pull request as ready for review August 13, 2024 16:32
@0xnm 0xnm requested review from a team as code owners August 13, 2024 16:32
@0xnm 0xnm merged commit cf7bb08 into develop Aug 14, 2024
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/gradle-8.9-agp-8.5.2 branch August 14, 2024 08:03
@0xnm 0xnm mentioned this pull request Sep 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants