Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarking metrics data upload request issue #2227

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

Fix metrics data upload due to the modification of request body media type,

Actually "Metrics" and "Span" require different media type as intake.

"Span" API requires plain text so several span json can be combined in the same request, while "Metrics" API requires Json format, otherwise it refuses the request with 400 Bad request response.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork requested review from a team as code owners September 2, 2024 09:03
@ambushwork ambushwork force-pushed the yl/metrics/fix-upload-request branch from 04e8396 to 5da01c1 Compare September 3, 2024 08:19
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (87cc448) to head (5da01c1).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2227      +/-   ##
===========================================
- Coverage    70.02%   69.96%   -0.06%     
===========================================
  Files          727      727              
  Lines        27036    27044       +8     
  Branches      4556     4557       +1     
===========================================
- Hits         18931    18920      -11     
- Misses        6828     6838      +10     
- Partials      1277     1286       +9     

see 38 files with indirect coverage changes

@ambushwork ambushwork merged commit 572137a into develop Sep 3, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/metrics/fix-upload-request branch September 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants