Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6570: Fix Rum integration test verifyViewEventsOnSwipe #2326

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

There are two integration tests failing for very long time,

  • ConsentPendingGrantedFragmentTrackingTest.verifyViewEventsOnSwipe

  • ConsentGrantedFragmentTrackingTest.verifyViewEventsOnSwipe

This is due to the action we perform on the test activity never works:

onView(ViewMatchers.withId(R.id.tab_layout)).perform(ViewActions.swipeLeft())

It's a known issue of Espresso that swipe is not working on a view pager, so we can never perform the action that we want,

to fix it, I added two buttons on the layout to go to next or last page, and replace the swipe action by clicking the buttons.

Another issue is that in integration test we need to override the importance of the process otherwise we don't receive the event of application start

Motivation

RUM-6570

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork marked this pull request as ready for review October 17, 2024 09:03
@ambushwork ambushwork requested review from a team as code owners October 17, 2024 09:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (774c798) to head (0ef5e0d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2326      +/-   ##
===========================================
- Coverage    70.41%   70.40%   -0.01%     
===========================================
  Files          739      739              
  Lines        27536    27536              
  Branches      4614     4614              
===========================================
- Hits         19388    19385       -3     
- Misses        6866     6868       +2     
- Partials      1282     1283       +1     

see 35 files with indirect coverage changes

@ambushwork ambushwork merged commit f733850 into develop Oct 17, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/it/develop-fix-rum-test branch October 17, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants