Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6198: Add RadioButton Semantics Node Mapper #2381

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ambushwork
Copy link
Member

What does this PR do?

Add RadioButton Semantics Node Mapper.
Since we are not able to retrieve the image of button, we use shape to simulate the radio button.
And color of the button needs to be retrieved by reflection, here is a follow up tickets: RUM-7116

Motivation

RUM-6198

Demo

Sample App Session Replay
image image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.54%. Comparing base (0bba965) to head (d5be643).
Report is 2 commits behind head on feature/sr_compose.

Files with missing lines Patch % Lines
...appers/semantics/RadioButtonSemanticsNodeMapper.kt 94.44% 1 Missing and 1 partial ⚠️
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2381      +/-   ##
======================================================
- Coverage               69.61%   69.54%   -0.06%     
======================================================
  Files                     772      773       +1     
  Lines                   28719    28758      +39     
  Branches                 4885     4887       +2     
======================================================
+ Hits                    19990    19999       +9     
- Misses                   7365     7384      +19     
- Partials                 1364     1375      +11     
Files with missing lines Coverage Δ
...rnal/mappers/semantics/SemanticsWireframeMapper.kt 82.05% <100.00%> (+0.47%) ⬆️
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 84.00% <50.00%> (-2.96%) ⬇️
...appers/semantics/RadioButtonSemanticsNodeMapper.kt 94.44% <94.44%> (ø)

... and 29 files with indirect coverage changes

@ambushwork ambushwork force-pushed the yl/compose/add-switch-sample branch 3 times, most recently from 64699b5 to b671473 Compare November 7, 2024 14:49
@ambushwork ambushwork marked this pull request as ready for review November 7, 2024 15:28
@ambushwork ambushwork requested review from a team as code owners November 7, 2024 15:28
@ambushwork ambushwork merged commit 8a06cde into feature/sr_compose Nov 7, 2024
24 checks passed
@ambushwork ambushwork deleted the yl/compose/add-switch-sample branch November 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants