Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7302: Align log levels for sr already enabled #2399

Merged

Conversation

jonathanmos
Copy link
Member

What does this PR do?

Aligns the log levels with iOS for the error we output when a user tries to enable session replay twice (either on the same core or on different cores) - "Session Replay is already enabled"

Motivation

On iOS they output an error to the user and debug to the telemetry.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.75%. Comparing base (ff6002f) to head (8a6a881).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2399      +/-   ##
===========================================
- Coverage    69.82%   69.75%   -0.07%     
===========================================
  Files          763      763              
  Lines        28360    28363       +3     
  Branches      4763     4761       -2     
===========================================
- Hits         19801    19782      -19     
- Misses        7246     7258      +12     
- Partials      1313     1323      +10     
Files with missing lines Coverage Δ
...com/datadog/android/sessionreplay/SessionReplay.kt 72.09% <100.00%> (+2.86%) ⬆️

... and 31 files with indirect coverage changes

@jonathanmos jonathanmos marked this pull request as ready for review November 18, 2024 12:35
@jonathanmos jonathanmos requested review from a team as code owners November 18, 2024 12:35
@jonathanmos jonathanmos merged commit bd71625 into develop Nov 18, 2024
24 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/rum-7302/align-levels-sr-already-enabled branch November 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants