-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TextSemanticsNodeMapper to commonize the text wireframe logic #2401
Conversation
aed9992
to
3a808a2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2401 +/- ##
===========================================
- Coverage 69.82% 69.76% -0.06%
===========================================
Files 763 765 +2
Lines 28360 28363 +3
Branches 4763 4757 -6
===========================================
- Hits 19801 19786 -15
- Misses 7246 7266 +20
+ Partials 1313 1311 -2
|
...pose/src/main/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/StringUtils.kt
Outdated
Show resolved
Hide resolved
.../src/test/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/StringUtilsTest.kt
Outdated
Show resolved
Hide resolved
3a808a2
to
b369108
Compare
class StringUtilsTest { | ||
@Test | ||
fun `M return null W resolveAnnotatedString with null value`() { | ||
val result = resolveAnnotatedString(null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
For tests in this class Given
, When
, Then
comments seem to be missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
b369108
to
53e02fb
Compare
53e02fb
to
4748894
Compare
What does this PR do?
For the other semantics node mapper, we are probably going to reuse the part of the logic of resolving the text in current
TextSemanticsNodeMapper
, so in this PR, some functions are moved toAbstractSemanticsNodeMapper
orSemanticUtils
so it can be directly used by others.Review checklist (to be filled by reviewers)