Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7590 Correct the way we register the initial resources for TTNS metric #2439

Conversation

mariusc83
Copy link
Member

@mariusc83 mariusc83 commented Dec 6, 2024

What does this PR do?

We need to fix the way we are recording the initial resources needed for the TTNS metric computation by only doing this in the onSuccess callbacks once the resource event was persisted for upload. There are 2 special cases where the resource is stopped due to errors and these are treated separately.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Dec 6, 2024
@mariusc83 mariusc83 force-pushed the mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource branch 2 times, most recently from 82b5b95 to df03c5e Compare December 6, 2024 10:49
Base automatically changed from mconstantin/fix-the-way-we-record-last-interaction to feature/view-loading-times December 6, 2024 10:49
@mariusc83 mariusc83 force-pushed the mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource branch from df03c5e to bc9ab22 Compare December 6, 2024 10:53
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (426cd07) to head (199dec9).
Report is 2 commits behind head on feature/view-loading-times.

Files with missing lines Patch % Lines
...roid/rum/internal/domain/scope/RumResourceScope.kt 50.00% 0 Missing and 1 partial ⚠️
...ric/networksettled/NetworkSettledMetricResolver.kt 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/view-loading-times    #2439      +/-   ##
==============================================================
- Coverage                       70.07%   70.03%   -0.04%     
==============================================================
  Files                             775      775              
  Lines                           28708    28722      +14     
  Branches                         4809     4810       +1     
==============================================================
- Hits                            20116    20113       -3     
- Misses                           7273     7280       +7     
- Partials                         1319     1329      +10     
Files with missing lines Coverage Δ
...g/android/rum/internal/domain/scope/RumRawEvent.kt 100.00% <100.00%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 94.70% <100.00%> (-0.10%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 85.53% <100.00%> (-0.14%) ⬇️
...tadog/android/rum/internal/monitor/StorageEvent.kt 90.00% <100.00%> (ø)
...roid/rum/internal/domain/scope/RumResourceScope.kt 94.41% <50.00%> (-0.72%) ⬇️
...ric/networksettled/NetworkSettledMetricResolver.kt 95.12% <66.67%> (-2.25%) ⬇️

... and 21 files with indirect coverage changes

@mariusc83 mariusc83 marked this pull request as ready for review December 6, 2024 11:49
@mariusc83 mariusc83 requested review from a team as code owners December 6, 2024 11:49
@mariusc83 mariusc83 force-pushed the mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource branch from bc9ab22 to aa63ccf Compare December 9, 2024 10:31
@mariusc83 mariusc83 force-pushed the mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource branch from aa63ccf to 199dec9 Compare December 9, 2024 10:43
@mariusc83 mariusc83 requested a review from ambushwork December 9, 2024 10:49
@mariusc83 mariusc83 merged commit 558855a into feature/view-loading-times Dec 9, 2024
25 checks passed
@mariusc83 mariusc83 deleted the mconstantin/rum-7590/fix-the-way-we-record-the-initial-resource branch December 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants