-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-7631: Display captured text when the text has Ellipsis overflow #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
835220c
to
4e74cd1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2446 +/- ##
===========================================
- Coverage 70.09% 70.05% -0.04%
===========================================
Files 769 769
Lines 28509 28531 +22
Branches 4778 4789 +11
===========================================
+ Hits 19981 19985 +4
- Misses 7183 7207 +24
+ Partials 1345 1339 -6
|
mariusc83
reviewed
Dec 10, 2024
.../datadog/android/sessionreplay/compose/internal/mappers/semantics/TextSemanticsNodeMapper.kt
Outdated
Show resolved
Hide resolved
4e74cd1
to
f796202
Compare
0xnm
approved these changes
Dec 10, 2024
features/dd-sdk-android-session-replay-compose/consumer-rules.pro
Outdated
Show resolved
Hide resolved
.../datadog/android/sessionreplay/compose/internal/mappers/semantics/TextSemanticsNodeMapper.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/SemanticsUtilsTest.kt
Show resolved
Hide resolved
...c/test/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/SemanticsUtilsTest.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/com/datadog/android/sessionreplay/compose/internal/utils/SemanticsUtilsTest.kt
Outdated
Show resolved
Hide resolved
mariusc83
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f796202
to
7dc5f2c
Compare
jonathanmos
approved these changes
Dec 10, 2024
7dc5f2c
to
11ccc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On App side, if a text is too long,
overflow
can be defined to omit the overflow text, in Session Replay we need to display it correctly as much as possible:The PR use reflection to retrieve the real text which will be put in
StaticLayout
if the text overflow happens.Note that if
overflow = TextOverflow.Clip
, we are not able to handle it.Motivation
RUM-7631
Demo
Texts in yellow and red background are using
TextOverflow.Ellipsis
, Green one is usingTextOverflow.Clip
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)