RUMM-1153: Possibility to attach custom attributes to automatically collected RUM Resource events #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce event ended with error
0xnm
commented
Mar 9, 2021
| */ | ||
| open class DatadogInterceptor | ||
| internal constructor( | ||
| tracedHosts: List<String>, | ||
| tracedRequestListener: TracedRequestListener, | ||
| firstPartyHostDetector: FirstPartyHostDetector, | ||
| private val rumResourceAttributesProvider: RumResourceAttributesProvider = |
There was a problem hiding this comment.
it is not last in the argument list to keep lambda last to still have ctor() { lambda } syntax
mariusc83
reviewed
Mar 9, 2021
| .substringBeforeLast('.') | ||
| val noOpReturnType = ClassName(packageName, "NoOp${returnTypeDef.simpleName}") | ||
| funSpecBuilder.addStatement("return %T()", noOpReturnType) | ||
| val returnTypeElement = returnTypeDef as TypeElement |
sample/kotlin/src/main/kotlin/com/datadog/android/sample/SampleApplication.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android/src/test/kotlin/com/datadog/android/DatadogInterceptorTest.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
============================================
- Coverage 89.49% 89.40% -0.09%
+ Complexity 1455 1451 -4
============================================
Files 167 167
Lines 5015 5030 +15
Branches 583 583
============================================
+ Hits 4488 4497 +9
- Misses 336 341 +5
- Partials 191 192 +1 |
…atically collected RUM Resources
0xnm
force-pushed
the
nogorodnikov/rumm-1153/possibility-to-attach-custom-attributes-to-automatic-rum-resources
branch
from
6b40763
to
d84e2a8
Compare
mariusc83
approved these changes
Mar 10, 2021
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| @LargeTest | ||
| internal class ResourceTrackingTest { |
...ation/src/androidTest/kotlin/com/datadog/android/sdk/integration/rum/ResourceTrackingTest.kt
Outdated
Show resolved
Hide resolved
0xnm
force-pushed
the
nogorodnikov/rumm-1153/possibility-to-attach-custom-attributes-to-automatic-rum-resources
branch
from
419136d
to
889f8c6
Compare
xgouchet
approved these changes
Mar 11, 2021
0xnm
deleted the
nogorodnikov/rumm-1153/possibility-to-attach-custom-attributes-to-automatic-rum-resources
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change gives user a possibility to attach custom attributes to automatically collected RUM Resource events: either in the
OkHttpflow, or in theWebViewflow.Attributes are collected after the resource call is completed (with either
successorerroroutcome)Additional Notes
Resources are also automatically collected here, but this part is not covered by this PR, because this class is low level and not sure if it is needed. Can be addressed in another PR if needed though.
Review checklist (to be filled by reviewers)