Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken IntegrationTests target #1352

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: broken IntegrationTests target #1352

merged 1 commit into from
Jun 30, 2023

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 30, 2023 •
edited
Loading

What and why?

Since #1344 the develop branch DatadogIntegrationTests target is broken.

Figured this out after merging develop for #1328.

How?

Adapted tests to new model changes.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@ganeshnj ganeshnj requested a review from a team as a code owner June 30, 2023 11:14
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 30, 2023 •
edited
Loading

Datadog Report

Branch report: ganeshnj/fix/integ-tests-target
Commit report: abca88e

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 2178 Passed, 0 Skipped, 25m 54.5s Wall Time

@ganeshnj ganeshnj merged commit bfae9d6 into develop Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshnj @maciejburda