RUMM-610 Add memory consumption benchmarks for data upload #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds benchmarks required to test memory leaks fixed in #180. I'm adding this in a separate PR to
master
, as on the hotfix branch (starting from1.2.2
), the benchmark target's setup is incomplete.How?
I added
HTTPServerMock
instrumentation to the Benchmarks target (to run them against real server).The test is simple:
It measures the memory footprint of uploading 10 data requests,
10MB
each.Running without the fix (we can clearly see over
100MBs
of leaked data):Running with #180 hotfix (the memory footprint is negligible):
Review checklist