-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Re-enable CI Tests visibility #2108
Conversation
- temporarily disabled in dd-sdk-ios/pull/2096
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!!
/merge |
Devflow running:
|
Datadog ReportBranch report: ✅ 0 Failed, 3543 Passed, 0 Skipped, 2m 30.07s Total Time New Flaky Tests (1)
🔻 Code Coverage Decreases vs Default Branch (4) |
What and why?
📦 In #2096, we temporarily disabled CI Test instrumentation due to sporadic test failures caused by the following error:
I traced the root cause to the CI Tests SDK, which exceeded the open file descriptor limit when processing coverage files for the Test Impact Analysis feature. This led to failures with the
{Error Domain=NSPOSIXErrorDomain Code=24 "Too many open files"}
error.My whole investigation is documented here: internal doc.
How?
Since the issue arises only when Test Impact Analysis is enabled, I disabled it for
dd-sdk-ios
in the CI Test Optimization Settings page. This stops the CI Tests SDK from processing coverage files, preventing the file descriptor limit from being exceeded.A corresponding issue (
SDTEST-1200
) has been opened in CI Visibility for further investigation. Once resolved, we can re-enable TIA.Additionally, this PR refines error messages related to temporary directory management, improving clarity by pointing more directly to the failing code.
Review checklist
make api-surface
)