-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-6850: Add "Effective Sample Rate" to telemetry events #2127
RUM-6850: Add "Effective Sample Rate" to telemetry events #2127
Conversation
2ff120e
to
c6c64b6
Compare
Datadog ReportBranch report: ✅ 0 Failed, 3583 Passed, 0 Skipped, 2m 31.9s Total Time 🔻 Code Coverage Decreases vs Default Branch (7)
|
c6c64b6
to
0bde0a1
Compare
Datadog/IntegrationUnitTests/Public/CoreTelemetryIntegrationTests.swift
Outdated
Show resolved
Hide resolved
Datadog/IntegrationUnitTests/Public/CoreTelemetryIntegrationTests.swift
Outdated
Show resolved
Hide resolved
e730349
to
5211116
Compare
5211116
to
e625bd5
Compare
2466d30
to
813cfcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅 🎯 Well done, LG!
What and why?
This PR adds a new property
effectiveSampleRate
to all types of telemetry events.We want to know the actual rate applied to the events that is composed by all the sample rates, in the different layers, through which the event passes.
How?
Composes
effectiveSampleRate
with the globaltelemetrySampleRate
for:Logic centralized on
SampleRate
type alias:Review checklist
make api-surface
)