Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6850: Add more precision to Effective Sample Rate #2149

Conversation

simaoseica-dd
Copy link
Contributor

What and why?

It aligns the telemetry schema with the updates done on the Effective Sample Rate PR.
Effective Sample Rate has now support for floating points.

How?

By updating the RUMDataModels and the associated tests.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@simaoseica-dd simaoseica-dd requested review from a team as code owners December 16, 2024 16:52
mariedm
mariedm previously approved these changes Dec 17, 2024
@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-6850/add-more-precision-to-effective-sample-rate branch from 9a01cc2 to e0c3eea Compare December 17, 2024 12:31
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 17, 2024

Datadog Report

Branch report: simaoseica/RUM-6850/add-more-precision-to-effective-sample-rate
Commit report: 6c9ac6a
Test service: dd-sdk-ios

✅ 0 Failed, 772 Passed, 2819 Skipped, 36.94s Total duration (1m 54.28s time saved)

Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 👌 🌟

@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-6850/add-more-precision-to-effective-sample-rate branch from e0c3eea to 4dafb6f Compare December 17, 2024 14:00
@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-6850/add-more-precision-to-effective-sample-rate branch from 4dafb6f to 6c9ac6a Compare December 17, 2024 15:59
@simaoseica-dd simaoseica-dd merged commit 573a3f2 into develop Dec 17, 2024
15 checks passed
@maciejburda maciejburda mentioned this pull request Jan 2, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants