Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter config #2151

Merged
merged 6 commits into from
Dec 17, 2024
Merged

chore: Fix linter config #2151

merged 6 commits into from
Dec 17, 2024

Conversation

ncreated
Copy link
Member

What and why?

📦 This PR updates the linter configuration to cover all relevant Swift test files in the project, addressing coverage gaps in the existing test.swiftlint.yml configuration.

How?

  • Added new directories to the linter configuration.
  • Removed obsolete or irrelevant locations.
  • Updated code to align with the configuration.

New locations included:

+  - ../../TestUtilities
+  - ../../DatadogSessionReplay/SRSnapshotTests
+  - ../../Datadog/IntegrationUnitTests
+  - ../../E2ETests
+  - ../../BenchmarkTests/Runner
+  - ../../BenchmarkTests/Benchmarks

Locations removed:

-  - ../../Tests
-  - ../../TestUtilities/Sources
-  - ../../Datadog/E2ETests
-  - ../../Datadog/E2EInstrumentationTests

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@ncreated ncreated self-assigned this Dec 17, 2024
@ncreated ncreated marked this pull request as ready for review December 17, 2024 09:50
@ncreated ncreated requested review from a team as code owners December 17, 2024 09:50
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 17, 2024

Datadog Report

Branch report: ncreated/chore/fix-linter-config
Commit report: a9282e1
Test service: dd-sdk-ios

✅ 0 Failed, 3583 Passed, 0 Skipped, 2m 31.03s Total Time
🔻 Test Sessions change in coverage: 6 decreased, 3 increased, 5 no change

🔻 Code Coverage Decreases vs Default Branch (6)

This report shows up to 5 code coverage decreases.

  • test DatadogInternalTests iOS 80.51% (-0.03%) - Details
  • test DatadogWebViewTrackingTests iOS 18.6% (-0.03%) - Details
  • test DatadogCrashReportingTests tvOS 26.65% (-0.03%) - Details
  • test DatadogCrashReportingTests iOS 26.62% (-0.03%) - Details
  • test DatadogTraceTests tvOS 54.22% (-0.01%) - Details

@ncreated ncreated merged commit a97be1d into develop Dec 17, 2024
17 checks passed
@ncreated ncreated deleted the ncreated/chore/fix-linter-config branch December 17, 2024 11:31
@maciejburda maciejburda mentioned this pull request Jan 2, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants