Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-7484 Add placeholder for unknown SwiftUI content #2155

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Dec 18, 2024

How?

Return placeholder wireframe when an unknown SwiftUI content is encountered.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@maxep maxep requested review from a team as code owners December 18, 2024 14:55
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 18, 2024

Datadog Report

Branch report: maxep/RUM-7484/swiftui-placeholder
Commit report: 3780aec
Test service: dd-sdk-ios

✅ 0 Failed, 29 Passed, 3581 Skipped, 15.45s Total duration (2m 15.97s time saved)

mariedm
mariedm previously approved these changes Dec 18, 2024
@maxep maxep force-pushed the maxep/RUM-7484/swiftui-placeholder branch from 69a0d61 to c338f34 Compare December 18, 2024 16:45
@maxep
Copy link
Member Author

maxep commented Dec 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-18 16:53:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-18 17:34:26 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@maxep
Copy link
Member Author

maxep commented Dec 18, 2024

/remove

@dd-devflow
Copy link

dd-devflow bot commented Dec 18, 2024

Devflow running: /remove

View all feedbacks in Devflow UI.


2024-12-18 17:34:24 UTC ℹ️ Devflow: /remove

@maxep maxep force-pushed the maxep/RUM-7484/swiftui-placeholder branch from c338f34 to 3780aec Compare December 18, 2024 18:30
@maxep
Copy link
Member Author

maxep commented Dec 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-18 18:31:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-18 19:04:46 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in develop is 28m.


2024-12-18 19:31:40 UTC ℹ️ MergeQueue: This merge request was merged

@testable import DatadogSessionReplay

@available(iOS 13.0, tvOS 13.0, *)
class SwiftUIWireframesBuilderTests: XCTestCase {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants