-
Notifications
You must be signed in to change notification settings - Fork 145
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the build and some versions (#6466)
## Summary of changes Fix the build and the version-bump action ## Reason for change In #6457, @vandonr spotted that we accidentally, incorrectly, "bumped" the required version of cmake. ![image](https://github.com/user-attachments/assets/5843c1db-2dad-439e-8ed8-eeeb2d05def5) Additionally, the new calltargets_generated.g.cpp file _also_ now embeds the version, so we need to either update that, or stop embedding the version. @daniel-romano-DD is looking into the latter approach [here](#6464), so this PR is just a fix to unblock PRs. ## Implementation details - Revert the broken CMakeLists.txt - Fix the broken generated file - Be more discerning in our CMakeLists updates ## Test coverage Tested the version bump routine locally, and confirmed it works as expected now. ## Other details It would be _really_ nice if the version bumping just required bumping one or two values... That _might_ be somewhat feasible in the future, but for now...
- Loading branch information
1 parent
df53d90
commit c48a1f7
Showing
4 changed files
with
7 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters