minor corrections I spotted

DataDog · Dec 3, 2024 · fc2be2d · fc2be2d
1 parent cdfd317
commit fc2be2d
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/tracer/build/_build/Build.Utilities.cs b/tracer/build/_build/Build.Utilities.cs
@@ -323,6 +323,7 @@ partial class Build
     Target PrintSnapshotsDiff  => _ => _
       .Description("Prints snapshots differences from the current tests")
       .AssuredAfterFailure()
+      .OnlyWhenStatic(() => IsServerBuild)
       .Executes(() =>
       {
           var snapshotsDirectory = TestsDirectory / "snapshots";

diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AdoNet/ReaderCloseIntegration.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AdoNet/ReaderCloseIntegration.cs
@@ -8,7 +8,6 @@
 using System;
 using System.ComponentModel;
 using Datadog.Trace.ClrProfiler.CallTarget;
-using Datadog.Trace.Configuration;
 using Datadog.Trace.Iast;
 using Datadog.Trace.Vendors.Serilog;
 

diff --git a/tracer/src/Datadog.Trace/Iast/IastModule.cs b/tracer/src/Datadog.Trace/Iast/IastModule.cs
@@ -932,7 +932,7 @@ public bool AddDbValue(object instance, string? column, string value)
             if (context is not null)
             {
                 context.AddDbValue(column, value);
-                return false;
+                return true;
             }
 
             return false;

diff --git a/tracer/test/Datadog.Trace.Security.IntegrationTests/IAST/AspNetCore5IastDbTests.cs b/tracer/test/Datadog.Trace.Security.IntegrationTests/IAST/AspNetCore5IastDbTests.cs
@@ -23,7 +23,6 @@ public AspNetCore5IastDbTests(AspNetCoreTestFixture fixture, ITestOutputHelper o
 
     [SkippableTheory]
     [Trait("Category", "ArmUnsupported")]
-    [Trait("RunOnWindows", "True")]
     [InlineData("System.Data.SQLite")]
     [InlineData("Microsoft.Data.Sqlite")]
     [InlineData("System.Data.SqlClient")]
@@ -64,7 +63,6 @@ await VerifyHelper.VerifySpans(spansFiltered, settings)
 
     [SkippableTheory]
     [Trait("Category", "ArmUnsupported")]
-    [Trait("RunOnWindows", "True")]
     [InlineData("System.Data.SQLite")]
     [InlineData("Microsoft.Data.Sqlite")]
     [InlineData("System.Data.SqlClient")]
@@ -101,7 +99,6 @@ await VerifyHelper.VerifySpans(spansFiltered, settings)
 
     [SkippableTheory]
     [Trait("Category", "ArmUnsupported")]
-    [Trait("RunOnWindows", "True")]
     [InlineData("System.Data.SQLite")]
     [InlineData("Microsoft.Data.Sqlite")]
     [InlineData("System.Data.SqlClient")]