Simplify moving average calculator #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously going a bit overboard with keeping things atomic, when in reality we only need the current buckets and keep rate to be atomic
colin-higgins
approved these changes
Apr 7, 2021
zacharycmontoya
approved these changes
Apr 7, 2021
lucaspimentel
added
area:tracer
kevingosse
reviewed
Apr 7, 2021
kevingosse
reviewed
Apr 7, 2021
Co-authored-by: Lucas Pimentel-Ordyna <lucas.pimentel@datadoghq.com>
Co-authored-by: Kevin Gosse <krix33@gmail.com>
kevingosse
approved these changes
Apr 7, 2021
lucaspimentel
approved these changes
Apr 7, 2021
kevingosse
pushed a commit
that referenced
this pull request
Apr 20, 2021
This reverts commit 201247a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously going a bit overboard with keeping things atomic, when in reality we only need the current buckets and keep rate to be atomic.
@DataDog/apm-dotnet