Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http.route data to align with OpenTelemetry.Instrumentation.AspNetCore output #2989

Closed
wants to merge 49 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
5bda490
Collecting tags, http.url with query string and not raw, http.client_…
anna-git May 24, 2022
7d626ee
factorize ip collection
anna-git May 25, 2022
afe39e9
Collecting and testing route
anna-git Jun 22, 2022
adc9753
fix unit tests
anna-git Jun 2, 2022
bc6b8d0
fix conflicts remove error Id regex, scrubinlineguids should do it
anna-git Jun 30, 2022
85ff054
integration with aspnet web api 2
anna-git Jun 21, 2022
de0271a
Ip extraction and tests
anna-git Jun 21, 2022
bf5edb2
peer ip in network client ip
anna-git Jun 22, 2022
6bec42a
add possibility to disable query string collection
anna-git Jun 22, 2022
2ce77c4
fix url collection and add framework and snapshots
anna-git Jun 22, 2022
2312e32
Query string test fix for framework
anna-git Jun 27, 2022
81622a5
change regex to take into account encoded characters
anna-git Jun 28, 2022
6d0aec9
add ability of disabling collecting ip header
anna-git Jun 28, 2022
5f8ffa8
add throughput tests for query string
anna-git Jul 1, 2022
8a66358
add regex pattern to framework and test throuput
anna-git Jul 1, 2022
f8d32e9
obfuscator change timeout system for better perf
anna-git Jul 3, 2022
c30eb0a
timeout can be a setting for regex
anna-git Jul 4, 2022
07d39ec
add log
anna-git Jul 5, 2022
15ca67b
Increase timeout
anna-git Jul 5, 2022
02982b3
add timeout for integration tests security
anna-git Jul 5, 2022
4194b32
fix unit tests params
anna-git Jul 6, 2022
589d3ce
logs for instantiation
anna-git Jul 6, 2022
60c8b9e
add timeout logs
anna-git Jul 6, 2022
ca5b3fa
task run instead of factory
anna-git Jul 6, 2022
e77de59
improve logs
anna-git Jul 6, 2022
7bc267e
change way of starting tasks
anna-git Jul 6, 2022
25ad075
fix tests
anna-git Jul 6, 2022
f99a122
back to timeout on regex
anna-git Jul 6, 2022
8931f1d
fix ignore tags
anna-git Jul 8, 2022
74ca542
first modifications to comments
anna-git Jul 8, 2022
d262bcd
fix space
anna-git Jul 8, 2022
3824c2c
add a comment and change variable name to make it clearer
anna-git Jul 8, 2022
c5c4456
answer to comments
anna-git Jul 11, 2022
217fdcd
Remove confusing DD_HEADER_TAGS=User-Agent:http_useragent configurati…
zacharycmontoya Jul 15, 2022
a6a0720
Align AspNetCore http.route logic with OTEL's by setting http.route w…
zacharycmontoya Jul 19, 2022
a2dd44e
This commit updates the AspNetCoreIisMvc30Tests.InProcess snapshots.
zacharycmontoya Jul 19, 2022
a7bb2cf
This commit updates the AspNetCoreIisMvc30Tests.OutOfProcess snapshots.
zacharycmontoya Jul 19, 2022
f690d12
This commit updates the AspNetCoreIisMvc31Tests.OutOfProcess snapshots.
zacharycmontoya Jul 19, 2022
d18dd25
This commit updates the AspNetCoreIisMvc31Tests.InProcess snapshots.
zacharycmontoya Jul 19, 2022
501069a
This commit updates the AspNetCoreMvc30Tests snapshots.
zacharycmontoya Jul 19, 2022
3fe0b1a
This commit updates the AspNetCoreMvc31Tests snapshots.
zacharycmontoya Jul 19, 2022
4c2eb1f
This commit updates the AspNetCoreMvc31QueryStringTests snapshots.
zacharycmontoya Jul 19, 2022
c88836f
This commit updates the AspNetCoreMvc21Tests snapshots.
zacharycmontoya Jul 19, 2022
bbc50e2
This commit updates the AspNetCoreIisMvc21Tests.OutOfProcess snapshots.
zacharycmontoya Jul 19, 2022
dc203e0
This commit updates the AspNetCoreIisMinimalApiTests.OutOfProcess sna…
zacharycmontoya Jul 19, 2022
dc719bb
This commit updates the AspNetCoreIisMinimalApiTests.InProcess snapsh…
zacharycmontoya Jul 19, 2022
4034291
This commit updates the AspNetCoreMinimalApiTests snapshots.
zacharycmontoya Jul 19, 2022
79fdcf8
Align AspNetCore http.route logic with OTEL's by removing all other c…
zacharycmontoya Jul 19, 2022
248e2e3
This commit updates the AspNetCore*MinimalApiTests *.WithFF snapshots.
zacharycmontoya Jul 19, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: api/delay/{seconds},
http.status_code: 200,
http.url: http://localhost:00000/api/delay/0,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ at Samples.AspNetCoreMvc.Controllers.HomeController.ThrowException(),
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: bad-request,
http.status_code: 500,
http.url: http://localhost:00000/bad-request,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: delay/{seconds},
http.status_code: 200,
http.url: http://localhost:00000/delay/0,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ System.Exception: Exception of type 'System.Exception' was thrown.
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: handled-exception,
http.status_code: 500,
http.url: http://localhost:00000/handled-exception,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ at Samples.AspNetCoreMvc.Controllers.HomeController.StatusCodeTestString(String
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code-string/{statusCode},
http.status_code: 500,
http.url: http://localhost:00000/status-code-string/%5B200%5D,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code/{statusCode},
http.status_code: 203,
http.url: http://localhost:00000/status-code/203,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code/{statusCode},
http.status_code: 402,
http.url: http://localhost:00000/status-code/402,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code/{statusCode},
http.status_code: 500,
http.url: http://localhost:00000/status-code/500,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: {controller=home}/{action=index}/{id?},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conventional routing

http.status_code: 200,
http.url: http://localhost:00000/,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ at Samples.AspNetCoreMvc.Controllers.HomeController.StatusCodeTestString(String
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code-string/{statuscode},
http.route: status-code-string/{statusCode},
http.status_code: 500,
http.url: http://localhost:00000/status-code-string/%5B200%5D,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code/{statuscode},
http.route: status-code/{statusCode},
http.status_code: 203,
http.url: http://localhost:00000/status-code/203,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code/{statuscode},
http.route: status-code/{statusCode},
http.status_code: 402,
http.url: http://localhost:00000/status-code/402,
http.useragent: testhelper,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
http.client_ip: 127.0.0.1,
http.method: GET,
http.request.headers.host: localhost:00000,
http.route: status-code/{statuscode},
http.route: status-code/{statusCode},
http.status_code: 500,
http.url: http://localhost:00000/status-code/500,
http.useragent: testhelper,
Expand Down