-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update http.route
data to align with OpenTelemetry.Instrumentation.AspNetCore output
#2989
Closed
+8,594
−2,088
Closed
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
5bda490
Collecting tags, http.url with query string and not raw, http.client_…
anna-git 7d626ee
factorize ip collection
anna-git afe39e9
Collecting and testing route
anna-git adc9753
fix unit tests
anna-git bc6b8d0
fix conflicts remove error Id regex, scrubinlineguids should do it
anna-git 85ff054
integration with aspnet web api 2
anna-git de0271a
Ip extraction and tests
anna-git bf5edb2
peer ip in network client ip
anna-git 6bec42a
add possibility to disable query string collection
anna-git 2ce77c4
fix url collection and add framework and snapshots
anna-git 2312e32
Query string test fix for framework
anna-git 81622a5
change regex to take into account encoded characters
anna-git 6d0aec9
add ability of disabling collecting ip header
anna-git 5f8ffa8
add throughput tests for query string
anna-git 8a66358
add regex pattern to framework and test throuput
anna-git f8d32e9
obfuscator change timeout system for better perf
anna-git c30eb0a
timeout can be a setting for regex
anna-git 07d39ec
add log
anna-git 15ca67b
Increase timeout
anna-git 02982b3
add timeout for integration tests security
anna-git 4194b32
fix unit tests params
anna-git 589d3ce
logs for instantiation
anna-git 60c8b9e
add timeout logs
anna-git ca5b3fa
task run instead of factory
anna-git e77de59
improve logs
anna-git 7bc267e
change way of starting tasks
anna-git 25ad075
fix tests
anna-git f99a122
back to timeout on regex
anna-git 8931f1d
fix ignore tags
anna-git 74ca542
first modifications to comments
anna-git d262bcd
fix space
anna-git 3824c2c
add a comment and change variable name to make it clearer
anna-git c5c4456
answer to comments
anna-git 217fdcd
Remove confusing DD_HEADER_TAGS=User-Agent:http_useragent configurati…
zacharycmontoya a6a0720
Align AspNetCore http.route logic with OTEL's by setting http.route w…
zacharycmontoya a2dd44e
This commit updates the AspNetCoreIisMvc30Tests.InProcess snapshots.
zacharycmontoya a7bb2cf
This commit updates the AspNetCoreIisMvc30Tests.OutOfProcess snapshots.
zacharycmontoya f690d12
This commit updates the AspNetCoreIisMvc31Tests.OutOfProcess snapshots.
zacharycmontoya d18dd25
This commit updates the AspNetCoreIisMvc31Tests.InProcess snapshots.
zacharycmontoya 501069a
This commit updates the AspNetCoreMvc30Tests snapshots.
zacharycmontoya 3fe0b1a
This commit updates the AspNetCoreMvc31Tests snapshots.
zacharycmontoya 4c2eb1f
This commit updates the AspNetCoreMvc31QueryStringTests snapshots.
zacharycmontoya c88836f
This commit updates the AspNetCoreMvc21Tests snapshots.
zacharycmontoya bbc50e2
This commit updates the AspNetCoreIisMvc21Tests.OutOfProcess snapshots.
zacharycmontoya dc203e0
This commit updates the AspNetCoreIisMinimalApiTests.OutOfProcess sna…
zacharycmontoya dc719bb
This commit updates the AspNetCoreIisMinimalApiTests.InProcess snapsh…
zacharycmontoya 4034291
This commit updates the AspNetCoreMinimalApiTests snapshots.
zacharycmontoya 79fdcf8
Align AspNetCore http.route logic with OTEL's by removing all other c…
zacharycmontoya 248e2e3
This commit updates the AspNetCore*MinimalApiTests *.WithFF snapshots.
zacharycmontoya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conventional routing