Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler] Disable tiered compilation in integration tests #3519

Conversation

gleocadie
Copy link
Collaborator

@gleocadie gleocadie commented Nov 29, 2022

Summary of changes

Disable tiered compilation in profiler integration tests.

Reason for change

We have integration tests where profiler and tracer are running together. Tracer has disable tiered jit compilation for its integration tests (temporarily) see #3479

Implementation details

Set COMPlus_TieredCompilation=0.

Test coverage

Other details

@gleocadie gleocadie requested a review from a team as a code owner November 29, 2022 11:41
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Nov 29, 2022
Copy link
Contributor

@chrisnas chrisnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gleocadie gleocadie merged commit 315a682 into master Nov 29, 2022
@gleocadie gleocadie deleted the gleocadie/disable-tiered-jit-compilation-for-profiler-tracer-tests branch November 29, 2022 16:35
@github-actions github-actions bot added this to the vNext milestone Nov 29, 2022
gleocadie added a commit that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:profiler Issues related to the continous-profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants