Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trimming file #5080

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix trimming file #5080

merged 1 commit into from
Jan 18, 2024

Conversation

andrewlock
Copy link
Member

Summary of changes

Adds missing entry in trimming file

Reason for change

I suspect this was missed in the IAST headers PR

Implementation details

Added the missing line

Test coverage

This is the test

Other details

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 18, 2024
@andrewlock andrewlock requested a review from a team as a code owner January 18, 2024 11:45
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 18, 2024

Datadog Report

Branch report: andrew/ci/fix-trimming-file
Commit report: d8dfc81
Test service: dd-trace-dotnet

✅ 0 Failed, 270333 Passed, 1384 Skipped, 44m 21.07s Wall Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5080) - mean (70ms)  : 61, 79
     .   : milestone, 70,
    master - mean (73ms)  : 63, 84
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5080) - mean (956ms)  : 927, 984
     .   : milestone, 956,
    master - mean (1,028ms)  : 1003, 1053
     .   : milestone, 1028,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5080) - mean (105ms)  : 100, 110
     .   : milestone, 105,
    master - mean (106ms)  : 102, 110
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (5080) - mean (697ms)  : 675, 719
     .   : milestone, 697,
    master - mean (731ms)  : 714, 748
     .   : milestone, 731,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5080) - mean (90ms)  : 86, 94
     .   : milestone, 90,
    master - mean (90ms)  : 87, 93
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (5080) - mean (660ms)  : 638, 682
     .   : milestone, 660,
    master - mean (693ms)  : 669, 716
     .   : milestone, 693,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5080) - mean (188ms)  : 185, 192
     .   : milestone, 188,
    master - mean (189ms)  : 185, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (5080) - mean (1,070ms)  : 1046, 1095
     .   : milestone, 1070,
    master - mean (1,135ms)  : 1117, 1154
     .   : milestone, 1135,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5080) - mean (273ms)  : 268, 277
     .   : milestone, 273,
    master - mean (272ms)  : 267, 277
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5080) - mean (1,056ms)  : 1030, 1082
     .   : milestone, 1056,
    master - mean (1,086ms)  : 1064, 1109
     .   : milestone, 1086,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5080) - mean (261ms)  : 258, 264
     .   : milestone, 261,
    master - mean (261ms)  : 258, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5080) - mean (1,024ms)  : 999, 1049
     .   : milestone, 1024,
    master - mean (1,053ms)  : 1033, 1073
     .   : milestone, 1053,

Loading

@andrewlock andrewlock merged commit 596ab54 into master Jan 18, 2024
49 of 55 checks passed
@andrewlock andrewlock deleted the andrew/ci/fix-trimming-file branch January 18, 2024 14:03
@github-actions github-actions bot added this to the vNext milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants