Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we never run any call target instrumentations in partial trust #6290

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Ensure that we never run any call target instrumentations in partial trust #6290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions tracer/src/Datadog.Trace/ClrProfiler/CallTarget/CallTargetInvoker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public static class CallTargetInvoker

#if NETFRAMEWORK
private const string NamedSlotName = "Datadog_IISPreInitStart";
private static readonly bool IsRunningInPartialTrust;
private static bool _isIisPreStartInitComplete;

static CallTargetInvoker()
Expand All @@ -36,7 +37,18 @@ static CallTargetInvoker()
// This is added to the startup hook by the CorProfiler in CorProfiler::AddIISPreStartInitFlags()
// which sets the value to `false` when the InvokePreStartInitMethods() method starts, and sets it to
// `true` after it's finished. Only once it returns to `true` can we start running CallTarget integrations.
var state = AppDomain.CurrentDomain.GetData(NamedSlotName);
var currentDomain = AppDomain.CurrentDomain;
IsRunningInPartialTrust = !IsFullyTrusted(currentDomain);
if (IsRunningInPartialTrust)
{
// if we're in partial trust, we never want to run the CallTargetInvoker
// so no need to do any of the other work in this method either.
// This scenario could occur when two apps are running the same app pool,
// one with full trust and one with partial trust.
return;
}

var state = currentDomain.GetData(NamedSlotName);
if (state is bool boolState)
{
// we know we must be in IIS, so we need to check the app domain state
Expand Down Expand Up @@ -671,7 +683,7 @@ public static void LogException<TIntegration, TTarget>(Exception exception)
// in some scenarios that we definitely _shouldn't_ be running here, so
// strictly checking _isIisPreStartInitComplete instead.
#if NETFRAMEWORK
if (_isIisPreStartInitComplete)
if (!IsRunningInPartialTrust && _isIisPreStartInitComplete)
#endif
{
IntegrationOptions<TIntegration, TTarget>.LogException(exception);
Expand Down Expand Up @@ -701,6 +713,12 @@ public static unsafe CallTargetRefStruct CreateRefStruct(void* refStructPointer,
#if NETFRAMEWORK
private static bool CanExecuteCallTargetIntegration<TIntegration>([CallerMemberName] string callerName = null!)
tonyredondo marked this conversation as resolved.
Show resolved Hide resolved
{
if (IsRunningInPartialTrust)
{
// Never run any call target integrations
return false;
}

if (_isIisPreStartInitComplete)
{
return true;
Expand All @@ -717,6 +735,24 @@ private static bool CanExecuteCallTargetIntegration<TIntegration>([CallerMemberN
return returnValue;
}

private static bool IsFullyTrusted(AppDomain appDomain)
{
try
{
if (appDomain.IsHomogenous && appDomain.IsFullyTrusted)
{
new System.Security.Permissions.SecurityPermission(System.Security.Permissions.PermissionState.Unrestricted).Demand();
return true;
}
}
catch
{
// Any sort of error here isn't good
}

return false;
}

#else
// Compiler should inline this out of the condition checks completely
[MethodImpl(MethodImplOptions.AggressiveInlining)]
Expand Down
Loading