Filter out dead threads in runtime metrics #6298

kevingosse · 2024-11-18T14:07:58Z

Summary of changes

Filter out the dead threads in the runtime metrics when using process snapshot.

Reason for change

We originally relied only on the count in the PSS_THREAD_INFORMATION instance returned by PssQuerySnapshot. However, it does not only count threads that are alive, but also dead threads which handle isn't closed (the handle for dead managed threads is closed during finalization after a garbage collection, so they can hang around for a while, especially since threads tend to reach generation 2).

This can be demonstrated by this simple code:

internal class Program
{
    static void Main()
    {
        var threads = new Thread[50];

        for (var i = 0; i < threads.Length; i++)
        {
            threads[i] = new Thread(() => Thread.Sleep(1));
            threads[i].Start();
        }

        Thread.Sleep(1000);

        ProcessSnapshotRuntimeInformation.GetCurrentProcessMetrics(out _, out _, out var threadCount, out _);

        Console.WriteLine($"Thread count: {threadCount}");
    }
}

With the old code, this would display 58, even thought the task manager shows only 8 threads.

Implementation details

We now use PssWalkSnapshot to walk the snapshot and filter out the dead threads. I had to use a custom FILETIME struct to get the alignment correct in both 32/64 bits. In hindsight, this might have worked for PSS_PROCESS_INFORMATION as well (avoiding the need to have separate PSS_PROCESS_INFORMATION_32/PSS_PROCESS_INFORMATION_64), I might try to improve that in a future PR.

Test coverage

The runtime metrics are already covered by tests. We don't test for dead threads, but it seems hard to do in a reliable way (and I think we can all agree our CI is flaky enough at the moment).
Also, the existing test has a tolerance of 500 threads. Back then I couldn't explain why we got so much variation in the results, I guess now we have a reasonable explanation (it was changed in #5329, shortly after adding PSS support).

Because we add additional calls for each thread, it has an impact on performance so I ran some benchmarks.

With 50 threads (realistic):

| Method  | Mean       | Error    | StdDev   | Ratio | RatioSD |
|-------- |-----------:|---------:|---------:|------:|--------:|
| Process | 6,466.2 us | 71.57 us | 63.45 us | 63.15 |    9.80 |
| Old     |   104.9 us |  5.67 us | 16.71 us |  1.02 |    0.23 |
| New     |   127.1 us |  2.48 us |  2.65 us |  1.24 |    0.19 |

With 250 threads (extreme):

| Method  | Mean         | Error      | StdDev     | Ratio  | RatioSD |
|-------- |-------------:|-----------:|-----------:|-------:|--------:|
| Process | 17,621.58 us | 349.413 us | 564.238 us | 183.31 |   20.11 |
| Old     |     97.27 us |   3.801 us |  11.028 us |   1.01 |    0.16 |
| New     |    129.39 us |   2.299 us |   2.823 us |   1.35 |    0.14 |

We're 25 to 35% slower, but we're still orders of magnitude faster than using the .NET Process object.

Other details

Fixes #6172

andrewlock

LGTM 🙈

datadog-ddstaging · 2024-11-18T14:39:29Z

Datadog Report

Branch report: kevin/pss_dead_threads
Commit report: 1c78cc5
Test service: dd-trace-dotnet

✅ 0 Failed, 455778 Passed, 2751 Skipped, 19h 56m 28.36s Total Time

andrewlock · 2024-11-18T14:51:54Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6298) - mean (72ms)  : 63, 81
     .   : milestone, 72,
    master - mean (72ms)  : 64, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6298) - mean (1,112ms)  : 1091, 1133
     .   : milestone, 1112,
    master - mean (1,107ms)  : 1085, 1128
     .   : milestone, 1107,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6298) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6298) - mean (770ms)  : 757, 784
     .   : milestone, 770,
    master - mean (771ms)  : 757, 785
     .   : milestone, 771,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6298) - mean (93ms)  : 90, 97
     .   : milestone, 93,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6298) - mean (731ms)  : 711, 750
     .   : milestone, 731,
    master - mean (726ms)  : 707, 745
     .   : milestone, 726,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6298) - mean (191ms)  : 185, 197
     .   : milestone, 191,
    master - mean (191ms)  : 186, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6298) - mean (1,218ms)  : 1189, 1247
     .   : milestone, 1218,
    master - mean (1,213ms)  : 1190, 1236
     .   : milestone, 1213,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6298) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6298) - mean (949ms)  : 934, 965
     .   : milestone, 949,
    master - mean (948ms)  : 929, 967
     .   : milestone, 948,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6298) - mean (267ms)  : 263, 270
     .   : milestone, 267,
    master - mean (265ms)  : 261, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6298) - mean (932ms)  : 914, 951
     .   : milestone, 932,
    master - mean (931ms)  : 913, 950
     .   : milestone, 931,

andrewlock · 2024-11-18T20:47:30Z

Benchmarks Report for tracer 🐌

Benchmarks for #6298 compared to master:

3 benchmarks are faster, with geometric mean 1.179
2 benchmarks are slower, with geometric mean 1.119
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.01μs	40.6ns	177ns	0.012	0.00399	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	52.5ns	241ns	0.0262	0.0157	0.00523	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	51.6ns	193ns	1.03	0.301	0.0977	6.21 KB
#6298	`StartStopWithChild`	net6.0	7.96μs	43.8ns	273ns	0.0153	0.00767	0	5.61 KB
#6298	`StartStopWithChild`	netcoreapp3.1	10.1μs	51.6ns	258ns	0.015	0.005	0	5.8 KB
#6298	`StartStopWithChild`	net472	16.2μs	35.9ns	134ns	1.04	0.324	0.0971	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	501μs	250ns	968ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	645μs	335ns	1.3μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	873μs	454ns	1.7μs	0.434	3.3 KB
#6298	`WriteAndFlushEnrichedTraces`	net6.0	482μs	454ns	1.57μs	0	2.7 KB
#6298	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	310ns	1.2μs	0	2.7 KB
#6298	`WriteAndFlushEnrichedTraces`	net472	870μs	639ns	2.3μs	0.434	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	200μs	1.16μs	9.1μs	0.2	18.73 KB
master	`SendRequest`	netcoreapp3.1	222μs	1.25μs	9.29μs	0.222	20.89 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6298	`SendRequest`	net6.0	203μs	1.19μs	10.9μs	0.2	18.73 KB
#6298	`SendRequest`	netcoreapp3.1	214μs	1.17μs	6.6μs	0.217	20.89 KB
#6298	`SendRequest`	net472	0.000452ns	0.000228ns	0.000855ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	577μs	2.92μs	16.8μs	0.553	0	0	41.76 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	675μs	3μs	11.6μs	0.336	0	0	41.83 KB
master	`WriteAndFlushEnrichedTraces`	net472	868μs	3.23μs	12.5μs	8.3	2.62	0.437	53.28 KB
#6298	`WriteAndFlushEnrichedTraces`	net6.0	585μs	3.21μs	18.7μs	0.548	0	0	41.64 KB
#6298	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	681μs	3.65μs	19.3μs	0.329	0	0	41.8 KB
#6298	`WriteAndFlushEnrichedTraces`	net472	856μs	3.93μs	15.2μs	8.39	2.52	0.419	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	1.03ns	3.84ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	3.27ns	12.7ns	0.0131	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.09μs	1.04ns	3.75ns	0.156	0.00104	987 B
#6298	`ExecuteNonQuery`	net6.0	1.3μs	1.45ns	5.62ns	0.0143	0	1.02 KB
#6298	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.34ns	5.21ns	0.0138	0	1.02 KB
#6298	`ExecuteNonQuery`	net472	2.09μs	2.77ns	10.7ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.28μs	0.482ns	1.87ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.54μs	1.03ns	3.99ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.51μs	1.16ns	4.5ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.633ns	2.45ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.898ns	3.36ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.56μs	0.795ns	2.98ns	0.167	1.05 KB
#6298	`CallElasticsearch`	net6.0	1.21μs	0.626ns	2.26ns	0.0133	976 B
#6298	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.842ns	3.04ns	0.0132	976 B
#6298	`CallElasticsearch`	net472	2.65μs	3.07ns	11.9ns	0.157	995 B
#6298	`CallElasticsearchAsync`	net6.0	1.29μs	1.12ns	4.33ns	0.013	952 B
#6298	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.09ns	4.06ns	0.0135	1.02 KB
#6298	`CallElasticsearchAsync`	net472	2.62μs	2.86ns	11.1ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6298

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.197	1,508.61	1,260.67

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.51μs	0.534ns	2.07ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.857ns	3.2ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.8μs	0.547ns	2.12ns	0.145	915 B
#6298	`ExecuteAsync`	net6.0	1.26μs	0.763ns	2.86ns	0.0135	952 B
#6298	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.21ns	4.68ns	0.0128	952 B
#6298	`ExecuteAsync`	net472	1.76μs	0.457ns	1.77ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.3μs	3.14ns	12.2ns	0.0325	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.23μs	5.65ns	21.9ns	0.0368	2.85 KB
master	`SendAsync`	net472	7.23μs	8.75ns	33.9ns	0.494	3.12 KB
#6298	`SendAsync`	net6.0	4.45μs	1.91ns	7.4ns	0.0312	2.31 KB
#6298	`SendAsync`	netcoreapp3.1	5.25μs	1.69ns	6.31ns	0.0391	2.85 KB
#6298	`SendAsync`	net472	7.4μs	1.97ns	7.64ns	0.492	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.58μs	0.613ns	2.3ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.19μs	1.32ns	4.76ns	0.0221	1.64 KB
master	`EnrichedLog`	net472	2.7μs	5.51ns	21.3ns	0.25	1.57 KB
#6298	`EnrichedLog`	net6.0	1.49μs	1.34ns	5.03ns	0.0228	1.64 KB
#6298	`EnrichedLog`	netcoreapp3.1	2.28μs	2.46ns	9.22ns	0.0227	1.64 KB
#6298	`EnrichedLog`	net472	2.56μs	1.57ns	5.88ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	237ns	918ns	0.06	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	114ns	443ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	187ns	725ns	0.687	0.229	4.46 KB
#6298	`EnrichedLog`	net6.0	118μs	153ns	594ns	0	0	4.28 KB
#6298	`EnrichedLog`	netcoreapp3.1	124μs	117ns	453ns	0	0	4.28 KB
#6298	`EnrichedLog`	net472	153μs	123ns	478ns	0.692	0.231	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	2.25ns	8.73ns	0.0306	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.01μs	1.44ns	5.57ns	0.03	2.2 KB
master	`EnrichedLog`	net472	4.88μs	5.97ns	23.1ns	0.32	2.02 KB
#6298	`EnrichedLog`	net6.0	3.05μs	0.932ns	3.61ns	0.0304	2.2 KB
#6298	`EnrichedLog`	netcoreapp3.1	4.22μs	1.97ns	7.64ns	0.0297	2.2 KB
#6298	`EnrichedLog`	net472	4.86μs	1.61ns	6.03ns	0.318	2.02 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6298

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.113	1,316.63	1,464.89

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	0.646ns	2.5ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.73μs	1.12ns	4.34ns	0.0148	1.14 KB
master	`SendReceive`	net472	1.99μs	1.25ns	4.84ns	0.183	1.16 KB
#6298	`SendReceive`	net6.0	1.46μs	0.554ns	2.14ns	0.0161	1.14 KB
#6298	`SendReceive`	netcoreapp3.1	1.82μs	1.49ns	5.77ns	0.0154	1.14 KB
#6298	`SendReceive`	net472	2.14μs	0.847ns	3.28ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.95μs	0.924ns	3.46ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.85μs	2.7ns	10.5ns	0.021	1.65 KB
master	`EnrichedLog`	net472	4.3μs	1.44ns	5.4ns	0.323	2.04 KB
#6298	`EnrichedLog`	net6.0	2.78μs	2.15ns	8.32ns	0.0222	1.6 KB
#6298	`EnrichedLog`	netcoreapp3.1	3.96μs	1.04ns	3.88ns	0.0216	1.65 KB
#6298	`EnrichedLog`	net472	4.51μs	4.51ns	17.5ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6298

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.125	551.54	620.45

Faster 🎉 in #6298

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.215	493.56	406.34

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	493ns	0.527ns	2.04ns	0.00801	576 B
master	`StartFinishSpan`	netcoreapp3.1	552ns	0.94ns	3.64ns	0.00779	576 B
master	`StartFinishSpan`	net472	636ns	1.38ns	5.33ns	0.0917	578 B
master	`StartFinishScope`	net6.0	488ns	0.365ns	1.42ns	0.00966	696 B
master	`StartFinishScope`	netcoreapp3.1	671ns	0.68ns	2.63ns	0.00929	696 B
master	`StartFinishScope`	net472	971ns	3.45ns	13.4ns	0.104	658 B
#6298	`StartFinishSpan`	net6.0	406ns	0.489ns	1.89ns	0.00807	576 B
#6298	`StartFinishSpan`	netcoreapp3.1	620ns	1.06ns	4.11ns	0.00781	576 B
#6298	`StartFinishSpan`	net472	680ns	0.569ns	2.2ns	0.0916	578 B
#6298	`StartFinishScope`	net6.0	491ns	0.864ns	3.35ns	0.00973	696 B
#6298	`StartFinishScope`	netcoreapp3.1	668ns	0.845ns	3.27ns	0.00945	696 B
#6298	`StartFinishScope`	net472	938ns	1.24ns	4.81ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6298

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.128	677.49	600.63

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	678ns	1.39ns	5.37ns	0.00992	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	966ns	0.736ns	2.85ns	0.00918	696 B
master	`RunOnMethodBegin`	net472	1.1μs	2.28ns	8.83ns	0.104	658 B
#6298	`RunOnMethodBegin`	net6.0	600ns	1.33ns	4.78ns	0.00991	696 B
#6298	`RunOnMethodBegin`	netcoreapp3.1	957ns	1.45ns	5.61ns	0.00946	696 B
#6298	`RunOnMethodBegin`	net472	1.21μs	0.77ns	2.98ns	0.104	658 B

kevingosse requested a review from a team as a code owner November 18, 2024 14:07

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Nov 18, 2024

andrewlock approved these changes Nov 18, 2024

View reviewed changes

kevingosse added 2 commits November 20, 2024 14:48

Filter out dead threads in runtime metrics

17f46de

Set thread tolerance back to 100

1c78cc5

kevingosse force-pushed the kevin/pss_dead_threads branch from a6a9f2a to 1c78cc5 Compare November 20, 2024 13:48

kevingosse merged commit ac2014c into master Nov 21, 2024
60 of 64 checks passed

kevingosse deleted the kevin/pss_dead_threads branch November 21, 2024 10:27

github-actions bot added this to the vNext-v3 milestone Nov 21, 2024

andrewlock added type:bug area:runtime-metrics labels Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filter out dead threads in runtime metrics #6298

Filter out dead threads in runtime metrics #6298

kevingosse commented Nov 18, 2024 •

edited

Loading

andrewlock left a comment

datadog-ddstaging bot commented Nov 18, 2024 •

edited

Loading

andrewlock commented Nov 18, 2024 •

edited

Loading

andrewlock commented Nov 18, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6298

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6298

Raw results

Raw results

Slower ⚠️ in #6298

Faster 🎉 in #6298

Raw results

Faster 🎉 in #6298

Raw results

Filter out dead threads in runtime metrics #6298

Filter out dead threads in runtime metrics #6298

Conversation

kevingosse commented Nov 18, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Nov 18, 2024 • edited Loading

Datadog Report

andrewlock commented Nov 18, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 18, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6298

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6298

Raw results

Raw results

Slower ⚠️ in #6298

Faster 🎉 in #6298

Raw results

Faster 🎉 in #6298

Raw results

kevingosse commented Nov 18, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 18, 2024 •

edited

Loading

andrewlock commented Nov 18, 2024 •

edited

Loading

andrewlock commented Nov 18, 2024 •

edited

Loading