-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try enabling debug in EnumerateAssemblyReferencesTest
#6352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
Datadog ReportBranch report: ✅ 0 Failed, 450949 Passed, 2720 Skipped, 19h 40m 16.74s Total Time New Flaky Tests (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6352) - mean (69ms) : 67, 71
. : milestone, 69,
master - mean (69ms) : 67, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6352) - mean (978ms) : 954, 1002
. : milestone, 978,
master - mean (978ms) : 954, 1002
. : milestone, 978,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6352) - mean (108ms) : 105, 111
. : milestone, 108,
master - mean (107ms) : 105, 110
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6352) - mean (679ms) : 661, 696
. : milestone, 679,
master - mean (678ms) : 659, 697
. : milestone, 678,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6352) - mean (91ms) : 89, 94
. : milestone, 91,
master - mean (91ms) : 88, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6352) - mean (628ms) : 608, 647
. : milestone, 628,
master - mean (632ms) : 616, 648
. : milestone, 632,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6352) - mean (190ms) : 187, 193
. : milestone, 190,
master - mean (190ms) : 187, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6352) - mean (1,097ms) : 1061, 1133
. : milestone, 1097,
master - mean (1,102ms) : 1067, 1136
. : milestone, 1102,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6352) - mean (277ms) : 272, 281
. : milestone, 277,
master - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6352) - mean (870ms) : 833, 907
. : milestone, 870,
master - mean (875ms) : 839, 911
. : milestone, 875,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6352) - mean (265ms) : 261, 270
. : milestone, 265,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6352) - mean (847ms) : 812, 882
. : milestone, 847,
master - mean (851ms) : 816, 887
. : milestone, 851,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6352) (11.343M) : 0, 11343308
master (11.288M) : 0, 11287537
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6352) (7.335M) : 0, 7334571
master (7.368M) : 0, 7368175
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.646M) : 0, 7646067
section Manual
master (11.262M) : 0, 11262396
section Manual + Automatic
This PR (6352) (6.789M) : 0, 6789079
master (6.845M) : 0, 6845270
section DD_TRACE_ENABLED=0
master (10.394M) : 0, 10394282
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6352) (9.645M) : 0, 9645044
master (9.359M) : 0, 9359375
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6352) (6.514M) : 0, 6514488
master (6.383M) : 0, 6382524
section Trace stats
master (6.787M) : 0, 6787327
section Manual
master (9.600M) : 0, 9600108
section Manual + Automatic
This PR (6352) (5.972M) : 0, 5972473
master (5.904M) : 0, 5903521
section DD_TRACE_ENABLED=0
master (8.752M) : 0, 8752034
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6352) (9.308M) : 0, 9307997
master (8.888M) : 0, 8887744
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6352) (6.195M) : 0, 6195407
master (5.904M) : 0, 5903587
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.431M) : 0, 6430906
section Manual
master (8.868M) : 0, 8868234
section Manual + Automatic
This PR (6352) (5.935M) : 0, 5935495
master (5.541M) : 0, 5540896
section DD_TRACE_ENABLED=0
master (8.290M) : 0, 8289928
|
Benchmarks Report for tracer 🐌Benchmarks for #6352 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉
|
Benchmark | Base Allocated | Diff Allocated | Change | Change % |
---|---|---|---|---|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.82 KB | 41.61 KB | -210 B | -0.50% |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | WriteAndFlushEnrichedTraces |
net6.0 | 558μs | 2.02μs | 7μs | 0.573 | 0 | 0 | 41.62 KB |
master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 678μs | 3.49μs | 17.1μs | 0.338 | 0 | 0 | 41.82 KB |
master | WriteAndFlushEnrichedTraces |
net472 | 847μs | 4.16μs | 17.7μs | 8.13 | 2.57 | 0.428 | 53.29 KB |
#6352 | WriteAndFlushEnrichedTraces |
net6.0 | 575μs | 2.94μs | 13.2μs | 0.576 | 0 | 0 | 41.58 KB |
#6352 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 663μs | 3.08μs | 11.9μs | 0.324 | 0 | 0 | 41.61 KB |
#6352 | WriteAndFlushEnrichedTraces |
net472 | 897μs | 4.58μs | 20.5μs | 8.21 | 2.28 | 0.456 | 53.28 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteNonQuery |
net6.0 | 1.23μs | 0.817ns | 2.94ns | 0.0141 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
netcoreapp3.1 | 1.76μs | 2.84ns | 9.85ns | 0.0138 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
net472 | 2.16μs | 1.99ns | 7.71ns | 0.157 | 0.00108 | 0 | 987 B |
#6352 | ExecuteNonQuery |
net6.0 | 1.27μs | 0.974ns | 3.77ns | 0.0142 | 0 | 0 | 1.02 KB |
#6352 | ExecuteNonQuery |
netcoreapp3.1 | 1.74μs | 1.58ns | 6.13ns | 0.0132 | 0 | 0 | 1.02 KB |
#6352 | ExecuteNonQuery |
net472 | 2.1μs | 1.42ns | 5.31ns | 0.156 | 0.00106 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.18μs | 0.683ns | 2.56ns | 0.0136 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.47μs | 0.638ns | 2.39ns | 0.0127 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.5μs | 1.38ns | 5.14ns | 0.158 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.41μs | 4.89ns | 19ns | 0.0135 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.75μs | 0.81ns | 2.92ns | 0.014 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.7μs | 1.69ns | 6.32ns | 0.167 | 0 | 0 | 1.05 KB |
#6352 | CallElasticsearch |
net6.0 | 1.22μs | 0.422ns | 1.58ns | 0.014 | 0 | 0 | 976 B |
#6352 | CallElasticsearch |
netcoreapp3.1 | 1.57μs | 0.894ns | 3.1ns | 0.0133 | 0 | 0 | 976 B |
#6352 | CallElasticsearch |
net472 | 2.61μs | 1.97ns | 7.63ns | 0.157 | 0 | 0 | 995 B |
#6352 | CallElasticsearchAsync |
net6.0 | 1.27μs | 0.676ns | 2.53ns | 0.0132 | 0 | 0 | 952 B |
#6352 | CallElasticsearchAsync |
netcoreapp3.1 | 1.65μs | 0.871ns | 3.37ns | 0.0134 | 0 | 0 | 1.02 KB |
#6352 | CallElasticsearchAsync |
net472 | 2.53μs | 2.03ns | 7.85ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.28μs | 0.408ns | 1.53ns | 0.0135 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.6μs | 0.646ns | 2.5ns | 0.0127 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.86μs | 1.25ns | 4.84ns | 0.144 | 0 | 0 | 915 B |
#6352 | ExecuteAsync |
net6.0 | 1.36μs | 0.401ns | 1.5ns | 0.0129 | 0 | 0 | 952 B |
#6352 | ExecuteAsync |
netcoreapp3.1 | 1.57μs | 1.07ns | 3.84ns | 0.0127 | 0 | 0 | 952 B |
#6352 | ExecuteAsync |
net472 | 1.78μs | 0.588ns | 2.2ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.35μs | 2.07ns | 8.01ns | 0.0327 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.38μs | 3.19ns | 11.9ns | 0.0375 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.33μs | 1.78ns | 6.9ns | 0.494 | 0 | 0 | 3.12 KB |
#6352 | SendAsync |
net6.0 | 4.43μs | 2.5ns | 9.37ns | 0.033 | 0 | 0 | 2.31 KB |
#6352 | SendAsync |
netcoreapp3.1 | 5.44μs | 3.36ns | 12.1ns | 0.0381 | 0 | 0 | 2.85 KB |
#6352 | SendAsync |
net472 | 7.3μs | 1.43ns | 5.53ns | 0.495 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.57μs | 0.551ns | 1.99ns | 0.0228 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.31μs | 1.37ns | 4.94ns | 0.0216 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.56μs | 1.45ns | 5.62ns | 0.249 | 0 | 0 | 1.57 KB |
#6352 | EnrichedLog |
net6.0 | 1.47μs | 0.762ns | 2.75ns | 0.0228 | 0 | 0 | 1.64 KB |
#6352 | EnrichedLog |
netcoreapp3.1 | 2.23μs | 0.84ns | 3.14ns | 0.0212 | 0 | 0 | 1.64 KB |
#6352 | EnrichedLog |
net472 | 2.53μs | 1.31ns | 4.89ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 120μs | 114ns | 440ns | 0.0602 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 122μs | 156ns | 584ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 151μs | 267ns | 1.03μs | 0.673 | 0.224 | 0 | 4.46 KB |
#6352 | EnrichedLog |
net6.0 | 118μs | 107ns | 400ns | 0.0601 | 0 | 0 | 4.28 KB |
#6352 | EnrichedLog |
netcoreapp3.1 | 124μs | 170ns | 659ns | 0.0623 | 0 | 0 | 4.28 KB |
#6352 | EnrichedLog |
net472 | 151μs | 179ns | 693ns | 0.677 | 0.226 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.12μs | 0.905ns | 3.5ns | 0.0311 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.38μs | 1.46ns | 5.45ns | 0.0306 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.88μs | 1.47ns | 5.69ns | 0.319 | 0 | 0 | 2.02 KB |
#6352 | EnrichedLog |
net6.0 | 3.13μs | 1.09ns | 4.22ns | 0.0298 | 0 | 0 | 2.2 KB |
#6352 | EnrichedLog |
netcoreapp3.1 | 4.26μs | 10.5ns | 40.8ns | 0.0294 | 0 | 0 | 2.2 KB |
#6352 | EnrichedLog |
net472 | 4.91μs | 2.72ns | 10.2ns | 0.321 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.35μs | 0.558ns | 2.16ns | 0.0162 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.72μs | 0.984ns | 3.81ns | 0.0147 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.1μs | 1.87ns | 7.25ns | 0.183 | 0 | 0 | 1.16 KB |
#6352 | SendReceive |
net6.0 | 1.43μs | 1.15ns | 4.45ns | 0.0159 | 0 | 0 | 1.14 KB |
#6352 | SendReceive |
netcoreapp3.1 | 1.76μs | 0.865ns | 3.35ns | 0.015 | 0 | 0 | 1.14 KB |
#6352 | SendReceive |
net472 | 2.04μs | 0.587ns | 2.28ns | 0.184 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.79μs | 0.924ns | 3.58ns | 0.0224 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.87μs | 1.35ns | 5.21ns | 0.0213 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.36μs | 1.97ns | 7.38ns | 0.323 | 0 | 0 | 2.04 KB |
#6352 | EnrichedLog |
net6.0 | 2.76μs | 1ns | 3.88ns | 0.0221 | 0 | 0 | 1.6 KB |
#6352 | EnrichedLog |
netcoreapp3.1 | 3.94μs | 1.28ns | 4.97ns | 0.0217 | 0 | 0 | 1.65 KB |
#6352 | EnrichedLog |
net472 | 4.44μs | 3.52ns | 13.6ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 447ns | 0.985ns | 3.81ns | 0.00811 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 581ns | 1.33ns | 4.98ns | 0.00753 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 585ns | 0.801ns | 3.1ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 476ns | 0.665ns | 2.58ns | 0.00966 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 729ns | 1.21ns | 4.38ns | 0.00953 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 860ns | 2.31ns | 8.94ns | 0.104 | 0 | 0 | 658 B |
#6352 | StartFinishSpan |
net6.0 | 410ns | 0.335ns | 1.3ns | 0.00801 | 0 | 0 | 576 B |
#6352 | StartFinishSpan |
netcoreapp3.1 | 649ns | 0.564ns | 2.11ns | 0.00776 | 0 | 0 | 576 B |
#6352 | StartFinishSpan |
net472 | 645ns | 0.492ns | 1.9ns | 0.0915 | 0 | 0 | 578 B |
#6352 | StartFinishScope |
net6.0 | 483ns | 0.387ns | 1.5ns | 0.00974 | 0 | 0 | 696 B |
#6352 | StartFinishScope |
netcoreapp3.1 | 750ns | 0.552ns | 2.14ns | 0.00936 | 0 | 0 | 696 B |
#6352 | StartFinishScope |
net472 | 892ns | 1.01ns | 3.78ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 602ns | 1.3ns | 5.03ns | 0.00969 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 895ns | 2.22ns | 8.32ns | 0.00956 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.13μs | 2.37ns | 9.18ns | 0.104 | 0 | 0 | 658 B |
#6352 | RunOnMethodBegin |
net6.0 | 652ns | 0.484ns | 1.88ns | 0.00985 | 0 | 0 | 696 B |
#6352 | RunOnMethodBegin |
netcoreapp3.1 | 926ns | 0.679ns | 2.63ns | 0.00929 | 0 | 0 | 696 B |
#6352 | RunOnMethodBegin |
net472 | 1.14μs | 1.9ns | 7.36ns | 0.104 | 0 | 0 | 658 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm willing to bet this will slow down the app enough that the crash will stop occurring 🙈
## Summary of changes Enable debug mode ## Reason for change This test crashes on shutdown when _apparently_ everything has exited gracefully. Enabling debug on the off-chance it reveals something ## Implementation details `DD_TRACE_DEBUG=1`
Summary of changes
Enable debug mode
Reason for change
This test crashes on shutdown when apparently everything has exited gracefully. Enabling debug on the off-chance it reveals something
Implementation details
DD_TRACE_DEBUG=1