-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dependabot for Azure Functions sample #6527
Enable dependabot for Azure Functions sample #6527
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 236171 Passed, 2093 Skipped, 19h 23m 53.38s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6527) - mean (69ms) : 66, 72
. : milestone, 69,
master - mean (69ms) : 66, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6527) - mean (979ms) : 959, 1000
. : milestone, 979,
master - mean (981ms) : 957, 1004
. : milestone, 981,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6527) - mean (107ms) : 105, 109
. : milestone, 107,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6527) - mean (677ms) : 663, 690
. : milestone, 677,
master - mean (678ms) : 665, 692
. : milestone, 678,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6527) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (92ms) : 90, 93
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6527) - mean (637ms) : 620, 654
. : milestone, 637,
master - mean (636ms) : 620, 652
. : milestone, 636,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6527) - mean (193ms) : 190, 197
. : milestone, 193,
master - mean (194ms) : 189, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6527) - mean (1,100ms) : 1071, 1130
. : milestone, 1100,
master - mean (1,103ms) : 1076, 1130
. : milestone, 1103,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6527) - mean (278ms) : 273, 283
. : milestone, 278,
master - mean (280ms) : 276, 284
. : milestone, 280,
section CallTarget+Inlining+NGEN
This PR (6527) - mean (871ms) : 844, 897
. : milestone, 871,
master - mean (873ms) : 849, 897
. : milestone, 873,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6527) - mean (268ms) : 262, 274
. : milestone, 268,
master - mean (269ms) : 264, 273
. : milestone, 269,
section CallTarget+Inlining+NGEN
This PR (6527) - mean (851ms) : 816, 886
. : milestone, 851,
master - mean (856ms) : 821, 890
. : milestone, 856,
|
Benchmarks Report for tracer 🐌Benchmarks for #6527 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.148 | 548.82 | 629.89 | |
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.126 | 513.26 | 578.15 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.221 | 813.54 | 666.27 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 398ns | 0.17ns | 0.659ns | 0.00803 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 549ns | 0.676ns | 2.62ns | 0.00766 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 674ns | 0.328ns | 1.23ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 513ns | 0.294ns | 1.1ns | 0.00968 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 814ns | 0.646ns | 2.33ns | 0.00913 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 903ns | 0.762ns | 2.95ns | 0.104 | 0 | 0 | 658 B |
#6527 | StartFinishSpan |
net6.0 | 397ns | 0.111ns | 0.428ns | 0.00816 | 0 | 0 | 576 B |
#6527 | StartFinishSpan |
netcoreapp3.1 | 630ns | 0.664ns | 2.3ns | 0.00755 | 0 | 0 | 576 B |
#6527 | StartFinishSpan |
net472 | 661ns | 0.0966ns | 0.374ns | 0.0915 | 0 | 0 | 578 B |
#6527 | StartFinishScope |
net6.0 | 578ns | 0.282ns | 1.09ns | 0.00987 | 0 | 0 | 696 B |
#6527 | StartFinishScope |
netcoreapp3.1 | 666ns | 0.418ns | 1.62ns | 0.00947 | 0 | 0 | 696 B |
#6527 | StartFinishScope |
net472 | 866ns | 0.382ns | 1.48ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6527
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.169
637.69
745.52
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.169 | 637.69 | 745.52 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 638ns | 0.272ns | 1.05ns | 0.00957 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 899ns | 0.5ns | 1.87ns | 0.00907 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.11μs | 0.93ns | 3.6ns | 0.104 | 0 | 0 | 658 B |
#6527 | RunOnMethodBegin |
net6.0 | 746ns | 0.367ns | 1.42ns | 0.00961 | 0 | 0 | 696 B |
#6527 | RunOnMethodBegin |
netcoreapp3.1 | 868ns | 0.564ns | 2.11ns | 0.00956 | 0 | 0 | 696 B |
#6527 | RunOnMethodBegin |
net472 | 1.08μs | 0.19ns | 0.711ns | 0.104 | 0 | 0 | 658 B |
Summary of changes
Try to enable dependabot for the Azure Functions v2 sample
Reason for change
In #6524 we had to remove our "normal" version bumping work, because the Azure Functions samples fundamentally don't work well with the
dotnet msbuild
approach. This PR attempts to give us some of that visibility back by explicitly configuring the azure functions sample in dependabotImplementation details
Added the sample directly to the yml. I think this is the most important one to track, as I think it's the only currently developed scenario that we expect to see updates.
Test coverage
Can't easily test the dependabot changes unfortunately AFAIK