Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot for Azure Functions sample #6527

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

Try to enable dependabot for the Azure Functions v2 sample

Reason for change

In #6524 we had to remove our "normal" version bumping work, because the Azure Functions samples fundamentally don't work well with the dotnet msbuild approach. This PR attempts to give us some of that visibility back by explicitly configuring the azure functions sample in dependabot

Implementation details

Added the sample directly to the yml. I think this is the most important one to track, as I think it's the only currently developed scenario that we expect to see updates.

Test coverage

Can't easily test the dependabot changes unfortunately AFAIK

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:test-apps apps used to test integrations labels Jan 10, 2025
@andrewlock andrewlock requested review from a team as code owners January 10, 2025 13:37
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 10, 2025

Datadog Report

Branch report: andrew/enable-dependabot-for-azure-functions
Commit report: 3beeb98
Test service: dd-trace-dotnet

✅ 0 Failed, 236171 Passed, 2093 Skipped, 19h 23m 53.38s Total Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6527) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6527) - mean (979ms)  : 959, 1000
     .   : milestone, 979,
    master - mean (981ms)  : 957, 1004
     .   : milestone, 981,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6527) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6527) - mean (677ms)  : 663, 690
     .   : milestone, 677,
    master - mean (678ms)  : 665, 692
     .   : milestone, 678,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6527) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6527) - mean (637ms)  : 620, 654
     .   : milestone, 637,
    master - mean (636ms)  : 620, 652
     .   : milestone, 636,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6527) - mean (193ms)  : 190, 197
     .   : milestone, 193,
    master - mean (194ms)  : 189, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6527) - mean (1,100ms)  : 1071, 1130
     .   : milestone, 1100,
    master - mean (1,103ms)  : 1076, 1130
     .   : milestone, 1103,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6527) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (280ms)  : 276, 284
     .   : milestone, 280,

    section CallTarget+Inlining+NGEN
    This PR (6527) - mean (871ms)  : 844, 897
     .   : milestone, 871,
    master - mean (873ms)  : 849, 897
     .   : milestone, 873,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6527) - mean (268ms)  : 262, 274
     .   : milestone, 268,
    master - mean (269ms)  : 264, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6527) - mean (851ms)  : 816, 886
     .   : milestone, 851,
    master - mean (856ms)  : 821, 890
     .   : milestone, 856,

Loading

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6527 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.221
  • 3 benchmarks are slower, with geometric mean 1.148
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.09μs 46.6ns 361ns 0.0121 0.00404 0 5.62 KB
master StartStopWithChild netcoreapp3.1 10.4μs 57.6ns 341ns 0.0211 0.0106 0 5.8 KB
master StartStopWithChild net472 16.3μs 53.1ns 206ns 1.03 0.31 0.0875 6.2 KB
#6527 StartStopWithChild net6.0 8.24μs 46.9ns 321ns 0.0204 0.00816 0 5.61 KB
#6527 StartStopWithChild netcoreapp3.1 10.3μs 49.2ns 209ns 0.02 0.01 0 5.8 KB
#6527 StartStopWithChild net472 16.4μs 65.2ns 252ns 1.03 0.301 0.0894 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 476μs 389ns 1.5μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 615ns 2.38μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 859μs 460ns 1.72μs 0.428 0 0 3.3 KB
#6527 WriteAndFlushEnrichedTraces net6.0 482μs 232ns 869ns 0 0 0 2.7 KB
#6527 WriteAndFlushEnrichedTraces netcoreapp3.1 662μs 278ns 1.04μs 0 0 0 2.7 KB
#6527 WriteAndFlushEnrichedTraces net472 860μs 727ns 2.82μs 0.431 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 152μs 893ns 8.75μs 0.149 0 0 14.47 KB
master SendRequest netcoreapp3.1 176μs 1.07μs 10.5μs 0.18 0 0 17.27 KB
master SendRequest net472 0.00113ns 0.000465ns 0.00174ns 0 0 0 0 b
#6527 SendRequest net6.0 154μs 871ns 7.02μs 0.137 0 0 14.47 KB
#6527 SendRequest netcoreapp3.1 171μs 1.11μs 10.8μs 0.175 0 0 17.27 KB
#6527 SendRequest net472 0.000247ns 0.000132ns 0.000494ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 570μs 3.08μs 17.4μs 0.553 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 3.38μs 19.1μs 0.345 0 0 41.67 KB
master WriteAndFlushEnrichedTraces net472 855μs 4.22μs 19.3μs 8.08 2.55 0.425 53.31 KB
#6527 WriteAndFlushEnrichedTraces net6.0 548μs 2.09μs 7.54μs 0.556 0 0 41.57 KB
#6527 WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 3.7μs 21.6μs 0.336 0 0 41.8 KB
#6527 WriteAndFlushEnrichedTraces net472 857μs 4.11μs 17μs 8.56 2.57 0.428 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.39μs 1.85ns 7.15ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.83μs 1.72ns 6.65ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 2.09μs 2.32ns 8.98ns 0.156 0.00104 0 987 B
#6527 ExecuteNonQuery net6.0 1.35μs 1.25ns 4.83ns 0.0142 0 0 1.02 KB
#6527 ExecuteNonQuery netcoreapp3.1 1.8μs 1.33ns 4.99ns 0.0134 0 0 1.02 KB
#6527 ExecuteNonQuery net472 2.09μs 1.79ns 6.92ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 0.658ns 2.46ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.63μs 0.505ns 1.96ns 0.013 0 0 976 B
master CallElasticsearch net472 2.53μs 1.29ns 4.65ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.28μs 0.405ns 1.51ns 0.0129 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.62μs 1.19ns 4.61ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.6μs 0.87ns 3.25ns 0.166 0 0 1.05 KB
#6527 CallElasticsearch net6.0 1.33μs 0.844ns 3.04ns 0.0139 0 0 976 B
#6527 CallElasticsearch netcoreapp3.1 1.64μs 0.66ns 2.47ns 0.013 0 0 976 B
#6527 CallElasticsearch net472 2.56μs 2.17ns 8.41ns 0.158 0 0 995 B
#6527 CallElasticsearchAsync net6.0 1.34μs 0.523ns 2.03ns 0.0134 0 0 952 B
#6527 CallElasticsearchAsync netcoreapp3.1 1.74μs 0.686ns 2.57ns 0.0138 0 0 1.02 KB
#6527 CallElasticsearchAsync net472 2.61μs 1.56ns 6.03ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.26μs 2.35ns 9.11ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 1.41ns 5.45ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.84μs 0.798ns 2.99ns 0.145 0 0 915 B
#6527 ExecuteAsync net6.0 1.38μs 1.05ns 3.92ns 0.0132 0 0 952 B
#6527 ExecuteAsync netcoreapp3.1 1.66μs 0.523ns 2.02ns 0.0127 0 0 952 B
#6527 ExecuteAsync net472 1.89μs 0.566ns 2.19ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.34μs 1.25ns 4.84ns 0.0304 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.33μs 1.55ns 6ns 0.0372 0 0 2.85 KB
master SendAsync net472 7.37μs 2.74ns 10.2ns 0.493 0 0 3.12 KB
#6527 SendAsync net6.0 4.45μs 1.33ns 4.96ns 0.0332 0 0 2.31 KB
#6527 SendAsync netcoreapp3.1 5.28μs 2.52ns 9.75ns 0.0372 0 0 2.85 KB
#6527 SendAsync net472 7.34μs 1.55ns 6ns 0.492 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.46μs 3.33ns 12.9ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.17μs 0.687ns 2.57ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.67μs 1.57ns 5.44ns 0.249 0 0 1.57 KB
#6527 EnrichedLog net6.0 1.47μs 0.907ns 3.39ns 0.0228 0 0 1.64 KB
#6527 EnrichedLog netcoreapp3.1 2.23μs 0.877ns 3.28ns 0.0213 0 0 1.64 KB
#6527 EnrichedLog net472 2.71μs 5.72ns 20.6ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 114ns 440ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 224ns 868ns 0 0 0 4.28 KB
master EnrichedLog net472 153μs 159ns 616ns 0.687 0.229 0 4.46 KB
#6527 EnrichedLog net6.0 115μs 147ns 571ns 0.0573 0 0 4.28 KB
#6527 EnrichedLog netcoreapp3.1 120μs 138ns 517ns 0 0 0 4.28 KB
#6527 EnrichedLog net472 153μs 507ns 1.96μs 0.677 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.05μs 1.17ns 4.53ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.16μs 1.01ns 3.63ns 0.0293 0 0 2.2 KB
master EnrichedLog net472 4.99μs 1.63ns 6.31ns 0.32 0 0 2.02 KB
#6527 EnrichedLog net6.0 3.12μs 1.05ns 3.94ns 0.0305 0 0 2.2 KB
#6527 EnrichedLog netcoreapp3.1 4.16μs 1.2ns 4.63ns 0.029 0 0 2.2 KB
#6527 EnrichedLog net472 4.85μs 1.03ns 3.72ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.29μs 0.626ns 2.42ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 0.496ns 1.86ns 0.015 0 0 1.14 KB
master SendReceive net472 2.1μs 1.05ns 3.78ns 0.183 0 0 1.16 KB
#6527 SendReceive net6.0 1.35μs 0.626ns 2.42ns 0.0162 0 0 1.14 KB
#6527 SendReceive netcoreapp3.1 1.76μs 0.931ns 3.61ns 0.0158 0 0 1.14 KB
#6527 SendReceive net472 2.09μs 1.75ns 6.78ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.8μs 0.896ns 3.47ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.89μs 2.42ns 9.35ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.4μs 2.15ns 8.05ns 0.322 0 0 2.04 KB
#6527 EnrichedLog net6.0 2.77μs 1.17ns 4.55ns 0.0222 0 0 1.6 KB
#6527 EnrichedLog netcoreapp3.1 4μs 12.5ns 48.6ns 0.0219 0 0 1.65 KB
#6527 EnrichedLog net472 4.48μs 3.1ns 12ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6527

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.148 548.82 629.89
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.126 513.26 578.15

Faster 🎉 in #6527

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.221 813.54 666.27

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 398ns 0.17ns 0.659ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 549ns 0.676ns 2.62ns 0.00766 0 0 576 B
master StartFinishSpan net472 674ns 0.328ns 1.23ns 0.0916 0 0 578 B
master StartFinishScope net6.0 513ns 0.294ns 1.1ns 0.00968 0 0 696 B
master StartFinishScope netcoreapp3.1 814ns 0.646ns 2.33ns 0.00913 0 0 696 B
master StartFinishScope net472 903ns 0.762ns 2.95ns 0.104 0 0 658 B
#6527 StartFinishSpan net6.0 397ns 0.111ns 0.428ns 0.00816 0 0 576 B
#6527 StartFinishSpan netcoreapp3.1 630ns 0.664ns 2.3ns 0.00755 0 0 576 B
#6527 StartFinishSpan net472 661ns 0.0966ns 0.374ns 0.0915 0 0 578 B
#6527 StartFinishScope net6.0 578ns 0.282ns 1.09ns 0.00987 0 0 696 B
#6527 StartFinishScope netcoreapp3.1 666ns 0.418ns 1.62ns 0.00947 0 0 696 B
#6527 StartFinishScope net472 866ns 0.382ns 1.48ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6527

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.169 637.69 745.52

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 638ns 0.272ns 1.05ns 0.00957 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 899ns 0.5ns 1.87ns 0.00907 0 0 696 B
master RunOnMethodBegin net472 1.11μs 0.93ns 3.6ns 0.104 0 0 658 B
#6527 RunOnMethodBegin net6.0 746ns 0.367ns 1.42ns 0.00961 0 0 696 B
#6527 RunOnMethodBegin netcoreapp3.1 868ns 0.564ns 2.11ns 0.00956 0 0 696 B
#6527 RunOnMethodBegin net472 1.08μs 0.19ns 0.711ns 0.104 0 0 658 B

@andrewlock andrewlock merged commit 5f52dd1 into master Jan 13, 2025
122 of 124 checks passed
@andrewlock andrewlock deleted the andrew/enable-dependabot-for-azure-functions branch January 13, 2025 09:52
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:test-apps apps used to test integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants