-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing build dependency #6538
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 236499 Passed, 1980 Skipped, 17h 51m 55.17s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6538) - mean (69ms) : 66, 71
. : milestone, 69,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6538) - mean (980ms) : 960, 999
. : milestone, 980,
master - mean (979ms) : 948, 1010
. : milestone, 979,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6538) - mean (108ms) : 106, 110
. : milestone, 108,
master - mean (107ms) : 105, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6538) - mean (680ms) : 663, 697
. : milestone, 680,
master - mean (678ms) : 664, 693
. : milestone, 678,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6538) - mean (91ms) : 89, 92
. : milestone, 91,
master - mean (91ms) : 89, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6538) - mean (635ms) : 617, 652
. : milestone, 635,
master - mean (635ms) : 620, 649
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6538) - mean (194ms) : 189, 199
. : milestone, 194,
master - mean (194ms) : 190, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6538) - mean (1,107ms) : 1069, 1145
. : milestone, 1107,
master - mean (1,103ms) : 1066, 1140
. : milestone, 1103,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6538) - mean (278ms) : 273, 282
. : milestone, 278,
master - mean (277ms) : 274, 281
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6538) - mean (874ms) : 846, 903
. : milestone, 874,
master - mean (870ms) : 843, 897
. : milestone, 870,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6538) - mean (268ms) : 264, 272
. : milestone, 268,
master - mean (267ms) : 263, 271
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6538) - mean (852ms) : 815, 889
. : milestone, 852,
master - mean (852ms) : 825, 878
. : milestone, 852,
|
Summary of changes
Adds missing dependency
Reason for change
Without it, the stage can start before the samples are available
Implementation details
Add the missing value
Test coverage
This is the test
Other details
Broke in #6498, didn't notice before because it shouldn't be done first, unless we're under a lot of CI pressure