Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop testing for macos-12 #6572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andrewlock
Copy link
Member

Summary of changes

The macos-12 image is deprecated, and is no longer available, so is causing build failures

Reason for change

We can't use it

Implementation details

Remove macos-12

Test coverage

Less now

Other details

macos-15 agents are available, I'll add testing for those in a separate PR

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Jan 17, 2025
@andrewlock andrewlock requested a review from a team as a code owner January 17, 2025 16:37
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 17, 2025

Datadog Report

Branch report: andrew/ci/drop-macos-12
Commit report: 4fd1280
Test service: dd-trace-dotnet

✅ 0 Failed, 236452 Passed, 1971 Skipped, 18h 51m 17.06s Total Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6572) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6572) - mean (986ms)  : 959, 1013
     .   : milestone, 986,
    master - mean (987ms)  : 962, 1013
     .   : milestone, 987,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6572) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6572) - mean (680ms)  : 666, 694
     .   : milestone, 680,
    master - mean (681ms)  : 668, 695
     .   : milestone, 681,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6572) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6572) - mean (635ms)  : 621, 650
     .   : milestone, 635,
    master - mean (635ms)  : 620, 650
     .   : milestone, 635,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6572) - mean (192ms)  : 187, 196
     .   : milestone, 192,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6572) - mean (1,096ms)  : 1064, 1128
     .   : milestone, 1096,
    master - mean (1,087ms)  : 1060, 1114
     .   : milestone, 1087,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6572) - mean (275ms)  : 272, 279
     .   : milestone, 275,
    master - mean (276ms)  : 270, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6572) - mean (869ms)  : 842, 897
     .   : milestone, 869,
    master - mean (863ms)  : 839, 886
     .   : milestone, 863,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6572) - mean (264ms)  : 258, 270
     .   : milestone, 264,
    master - mean (264ms)  : 260, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6572) - mean (856ms)  : 808, 905
     .   : milestone, 856,
    master - mean (847ms)  : 808, 886
     .   : milestone, 847,

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants