-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade(tracer): Support & use libdatadog's library_config crate #6615
base: baptiste.foy/bump-libdatadog-15
Are you sure you want to change the base?
upgrade(tracer): Support & use libdatadog's library_config crate #6615
Conversation
ecc176f
to
d01d9f6
Compare
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 49 occurrences of : + "exceptionHash": "ScrubbedValue",
+ "exceptionId": "ScrubbedValue",
+ "frameIndex": "ScrubbedValue",
1 occurrences of : - "value": "'3','32.38','Vins et alcools Chevalier','John',",
+ "value": "'3','32','Vins et alcools Chevalier','John',",
[...]
- "value": "'Reims','51100','France')",
- "source": 0
- },
- {
- "value": ";\nSELECT OrderID FROM Orders ORDER BY OrderID DESC LIMIT 1;"
+ "value": "'Reims','51100','France');\nSELECT OrderID FROM Orders ORDER BY OrderID DESC LIMIT 1;"
15 occurrences of : + _dd.appsec.user.collection_mode: sdk
1 occurrences of : + appsec.events.users.login.success.usr.login: my-id,
1 occurrences of : + appsec.events.users.login.failure.usr.login: my-id,
14 occurrences of : + _dd.appsec.user.collection_mode: sdk,
6 occurrences of : + _dd.appsec.fp.http.header: hdr-0000000100-3626b5f8-2-da57b738,
+ _dd.appsec.fp.http.network: net-1-1000000000,
+ _dd.appsec.fp.session: ssn-<fingerprint>,
|
79274ef
to
b8208a8
Compare
Datadog ReportBranch report: ❌ 11804 Failed (9 Known Flaky), 87209 Passed, 576 Skipped, 1h 24m 30.77s Total Time ❌ Failed Tests (11804)
|
db5e906
to
aec533c
Compare
b8a07ed
to
a31d5ce
Compare
a31d5ce
to
4dde6e4
Compare
2d6b37b
to
bc16be6
Compare
bc16be6
to
6f06f3d
Compare
Summary of changes
tbd
Reason for change
tbd
Implementation details
The core of the logic is in
shared/library_config.cpp
. It imports libdatadog's code to:Then it is called in the Native Profiler's
Configuration.cpp
to be applied in the profiler'sConfiguration
objectIt is also embedded in the native's tracer
interop.cpp
so it can be called as a new configuration layer in the managed tracer.Test coverage
tbd
Other details
Datadog.Trace
altogether... I tried to follow [Profiler] Use Vcpkg download and install native dependencies (libdatadog) #6388 but as I don't have a Windows machine to test it's pretty much trial and error. For now I think I'm missing theSetupVcpkg
build step.TODO:
ShouldRewriteProfilerMaps
to use the library-config methods so we can load the profiler natively?