Skip to content

Fix edge case with loading instrumentations #6815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Fix edge case with loading instrumentations #6815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13dc0a1
Add some modules that are preventing instrumentation on .NET console …
zacharycmontoya Mar 27, 2025
1917547
Add another module to be skipped
zacharycmontoya Apr 2, 2025
2848bc3
Instead of ignoring the System.Security.* modules for instrumentation
zacharycmontoya Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tracer/src/Datadog.Tracer.Native/cor_profiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,6 +1638,9 @@ HRESULT STDMETHODCALLTYPE CorProfiler::JITCompilationStarted(FunctionID function
}
else if (module_metadata->assemblyName == WStr("System") ||
module_metadata->assemblyName == WStr("System.Net.Http") ||
module_metadata->assemblyName == WStr("System.Security.AccessControl") ||
module_metadata->assemblyName == WStr("System.Security.Claims") ||
module_metadata->assemblyName == WStr("System.Security.Principal.Windows") ||
module_metadata->assemblyName == WStr("System.Linq")) // Avoid instrumenting System.Linq which is used as part of the async state machine
{
valid_startup_hook_callsite = false;
Expand Down
Loading