Skip to content

[AWS Lambda] Add request-id as header to Lambda start/end invocation #7835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 21, 2025
Merged

[AWS Lambda] Add request-id as header to Lambda start/end invocation #7835

merged 10 commits into from
Nov 21, 2025
+83 −34

Conversation

@rithikanarayan
Copy link
Contributor

@rithikanarayan rithikanarayan commented Nov 17, 2025 •
edited
Loading

Summary of changes

Adds lambda-runtime-aws-request-id header in start invocation and end invocation requests from tracer to extension. Assigns header to the aws request id of the span.

Reason for change

Allows the lambda extension to identify which start/end invocation requests belong to which invocation if multiple Lambda requests are being served concurrently.

Implementation details

Uses the LambdaContext from the IInvocationRequest proxyinstance to get the aws-request-id in SendStartInvocation and adds it to request headers in WriteRequestHeaders. Saves the aws-request-id as part of the state passed from OnDelegateBegin to EndInvocationAsync. EndInvocationAsync passes the state down to GetEndInvocationRequest, which adds it to the request headers.

Updates the LambdaCommonTests and LambdaRequestBuilderTests to match new function signatures with state passed down and to test for the assignment to the lambda-runtime-aws-request-id.

Test coverage

Added unit test in LambdaRequestBuilderTests to check for lambda-runtime-aws-request-id header and value in end invocation request. Manually tested for headers in start and end invocation using custom dd-trace-dotnet layer arn:aws:lambda:sa-east-1:425362996713:layer:dotnet-request-id-header-rithika:2 and custom lambda extension arn:aws:lambda:sa-east-1:425362996713:layer:Debug-extension-rithika:1 which prints the start and end invocation headers. Sample trace with logs of the headers here

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 17, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7835) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.40 ± (75.19 - 75.94) ms76.44 ± (76.47 - 77.44) ms+1.4%✅⬆️
.NET Framework 4.8 - Bailout
duration79.99 ± (79.97 - 80.76) ms80.56 ± (80.70 - 81.66) ms+0.7%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1053.02 ± (1055.21 - 1070.90) ms1065.12 ± (1070.53 - 1082.17) ms+1.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms23.01 ± (22.92 - 23.09) ms22.82 ± (22.74 - 22.90) ms-0.8%✅
process.time_to_main_ms88.34 ± (87.85 - 88.82) ms87.60 ± (87.11 - 88.09) ms-0.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.90 ± (10.90 - 10.91) MB10.90 ± (10.90 - 10.91) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.77 ± (22.72 - 22.83) ms22.78 ± (22.71 - 22.85) ms+0.0%✅⬆️
process.time_to_main_ms88.65 ± (88.25 - 89.05) ms88.69 ± (88.27 - 89.11) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.94 - 10.95) MB10.95 ± (10.94 - 10.95) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms223.35 ± (221.89 - 224.81) ms221.71 ± (219.89 - 223.52) ms-0.7%✅
process.time_to_main_ms505.03 ± (503.39 - 506.67) ms501.79 ± (500.50 - 503.07) ms-0.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.69 ± (47.67 - 47.71) MB47.73 ± (47.71 - 47.75) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.5%✅
.NET 6 - Baseline
process.internal_duration_ms21.89 ± (21.81 - 21.96) ms21.62 ± (21.54 - 21.70) ms-1.2%✅
process.time_to_main_ms77.52 ± (77.12 - 77.92) ms75.74 ± (75.36 - 76.11) ms-2.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.60) MB10.62 ± (10.62 - 10.62) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.53 ± (21.47 - 21.59) ms21.59 ± (21.52 - 21.66) ms+0.3%✅⬆️
process.time_to_main_ms76.44 ± (76.09 - 76.78) ms76.75 ± (76.35 - 77.16) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.68 ± (10.67 - 10.68) MB10.65 ± (10.65 - 10.66) MB-0.2%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms213.53 ± (212.15 - 214.91) ms210.94 ± (209.26 - 212.63) ms-1.2%✅
process.time_to_main_ms471.67 ± (470.36 - 472.98) ms468.82 ± (467.50 - 470.14) ms-0.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.06 ± (48.03 - 48.08) MB48.05 ± (48.03 - 48.07) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms20.05 ± (19.97 - 20.13) ms19.89 ± (19.82 - 19.96) ms-0.8%✅
process.time_to_main_ms75.78 ± (75.36 - 76.19) ms75.13 ± (74.73 - 75.53) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.65 ± (7.65 - 7.66) MB7.64 ± (7.64 - 7.65) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.87 ± (19.79 - 19.95) ms20.02 ± (19.94 - 20.09) ms+0.7%✅⬆️
process.time_to_main_ms76.14 ± (75.76 - 76.53) ms76.78 ± (76.43 - 77.13) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.71) MB7.70 ± (7.69 - 7.70) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms194.72 ± (193.74 - 195.71) ms194.73 ± (193.77 - 195.68) ms+0.0%✅⬆️
process.time_to_main_ms460.45 ± (459.19 - 461.72) ms461.09 ± (459.91 - 462.26) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.51 ± (36.47 - 36.55) MB36.59 ± (36.55 - 36.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.6%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.49 ± (192.48 - 193.15) ms197.74 ± (197.10 - 198.10) ms+2.7%✅⬆️
.NET Framework 4.8 - Bailout
duration196.45 ± (196.32 - 196.89) ms200.00 ± (199.47 - 200.50) ms+1.8%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1105.62 ± (1110.55 - 1119.78) ms1121.31 ± (1125.01 - 1135.50) ms+1.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.95 ± (187.61 - 188.28) ms188.53 ± (188.08 - 188.97) ms+0.3%✅⬆️
process.time_to_main_ms80.53 ± (80.31 - 80.75) ms80.83 ± (80.60 - 81.06) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (16.08 - 16.14) MB16.11 ± (16.08 - 16.13) MB-0.0%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms188.12 ± (187.79 - 188.46) ms187.82 ± (187.54 - 188.10) ms-0.2%✅
process.time_to_main_ms82.03 ± (81.91 - 82.15) ms82.22 ± (82.08 - 82.35) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.09 ± (16.06 - 16.12) MB16.21 ± (16.18 - 16.23) MB+0.7%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms400.21 ± (397.59 - 402.82) ms402.09 ± (399.07 - 405.11) ms+0.5%✅⬆️
process.time_to_main_ms472.85 ± (472.21 - 473.50) ms470.48 ± (469.87 - 471.08) ms-0.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.64 ± (58.51 - 58.77) MB58.36 ± (58.23 - 58.50) MB-0.5%✅
runtime.dotnet.threads.count30 ± (29 - 30)29 ± (29 - 29)-0.2%✅
.NET 6 - Baseline
process.internal_duration_ms192.34 ± (191.99 - 192.69) ms192.74 ± (192.40 - 193.07) ms+0.2%✅⬆️
process.time_to_main_ms69.84 ± (69.66 - 70.02) ms69.94 ± (69.80 - 70.09) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.90 ± (15.75 - 16.06) MB16.07 ± (15.92 - 16.22) MB+1.0%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 19)+0.3%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms192.64 ± (192.24 - 193.05) ms191.91 ± (191.58 - 192.25) ms-0.4%✅
process.time_to_main_ms71.07 ± (70.93 - 71.21) ms71.01 ± (70.88 - 71.13) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.33 ± (16.24 - 16.43) MB16.15 ± (16.00 - 16.31) MB-1.1%✅
runtime.dotnet.threads.count20 ± (20 - 20)19 ± (19 - 20)-2.3%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms410.31 ± (407.81 - 412.80) ms412.25 ± (409.57 - 414.94) ms+0.5%✅⬆️
process.time_to_main_ms441.61 ± (440.91 - 442.32) ms441.93 ± (441.25 - 442.60) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.57 ± (58.42 - 58.72) MB58.80 ± (58.66 - 58.94) MB+0.4%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (30 - 30)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms190.41 ± (190.11 - 190.72) ms189.47 ± (189.14 - 189.80) ms-0.5%✅
process.time_to_main_ms69.35 ± (69.18 - 69.51) ms69.40 ± (69.19 - 69.61) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.74 ± (11.71 - 11.77) MB11.81 ± (11.77 - 11.84) MB+0.6%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.2%✅
.NET 8 - Bailout
process.internal_duration_ms189.89 ± (189.58 - 190.19) ms189.98 ± (189.74 - 190.23) ms+0.1%✅⬆️
process.time_to_main_ms70.52 ± (70.42 - 70.62) ms70.50 ± (70.39 - 70.60) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.81 ± (11.78 - 11.84) MB11.85 ± (11.82 - 11.88) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms368.20 ± (366.67 - 369.74) ms363.86 ± (362.38 - 365.33) ms-1.2%✅
process.time_to_main_ms429.74 ± (429.13 - 430.35) ms430.65 ± (430.08 - 431.22) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.73 ± (47.69 - 47.76) MB47.91 ± (47.88 - 47.94) MB+0.4%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (77ms)  : 70, 84
    master - mean (76ms)  : 70, 81

    section Bailout
    This PR (7835) - mean (81ms)  : 74, 89
    master - mean (80ms)  : 74, 86

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (1,076ms)  : 992, 1161
    master - mean (1,063ms)  : 977, 1149
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (118ms)  : 108, 129
    master - mean (119ms)  : 108, 129

    section Bailout
    This PR (7835) - mean (119ms)  : 110, 128
    master - mean (119ms)  : 110, 128

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (761ms)  : 703, 820
    master - mean (767ms)  : 705, 828
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (105ms)  : 96, 114
    master - mean (106ms)  : 98, 115

    section Bailout
    This PR (7835) - mean (106ms)  : 96, 115
    master - mean (105ms)  : 98, 112

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (716ms)  : 659, 773
    master - mean (718ms)  : 676, 760
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (104ms)  : 95, 114
    master - mean (104ms)  : 96, 113

    section Bailout
    This PR (7835) - mean (105ms)  : 98, 113
    master - mean (105ms)  : 96, 113

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (688ms)  : 659, 717
    master - mean (687ms)  : 655, 718
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (198ms)  : 190, 205
    master - mean (193ms)  : 189, 196

    section Bailout
    This PR (7835) - mean (200ms)  : 194, 206
    master - mean (197ms)  : 194, 199

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (1,130ms)  : 1054, 1206
    master - mean (1,115ms)  : 1045, 1185
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (278ms)  : 272, 283
    master - mean (277ms)  : 271, 283

    section Bailout
    This PR (7835) - mean (278ms)  : 274, 283
    master - mean (278ms)  : 273, 283

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (902ms)  : 854, 949
    master - mean (905ms)  : 854, 956
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (271ms)  : 266, 275
    master - mean (270ms)  : 266, 274

    section Bailout
    This PR (7835) - mean (271ms)  : 266, 276
    master - mean (272ms)  : 265, 279

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (888ms)  : 836, 941
    master - mean (884ms)  : 844, 924
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7835) - mean (269ms)  : 264, 274
    master - mean (269ms)  : 265, 273

    section Bailout
    This PR (7835) - mean (270ms)  : 267, 274
    master - mean (270ms)  : 265, 275

    section CallTarget+Inlining+NGEN
    This PR (7835) - mean (824ms)  : 799, 849
    master - mean (829ms)  : 812, 847
Loading

@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7835 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.140
  • 3 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7835

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.01 KB 6.06 KB 54 B 0.90%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 50.8ns 203ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 13.6μs 69.1ns 317ns 0 0 0 5.68 KB
master StartStopWithChild net472 22.3μs 123ns 776ns 0.97 0.431 0.108 6.01 KB
#7835 StartStopWithChild net6.0 11μs 55.3ns 259ns 0 0 0 5.52 KB
#7835 StartStopWithChild netcoreapp3.1 15.4μs 33.3ns 129ns 0 0 0 5.68 KB
#7835 StartStopWithChild net472 21.5μs 118ns 677ns 0.985 0.328 0.109 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 926μs 53.1ns 199ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.05ms 2.65μs 9.9μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.2ms 61.9ns 240ns 0 0 0 3.31 KB
#7835 WriteAndFlushEnrichedTraces net6.0 940μs 93.2ns 349ns 0 0 0 2.7 KB
#7835 WriteAndFlushEnrichedTraces netcoreapp3.1 1.05ms 113ns 422ns 0 0 0 2.7 KB
#7835 WriteAndFlushEnrichedTraces net472 1.22ms 504ns 1.95μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.08μs 5.6ns 26.8ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.37μs 6.78ns 28.8ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.01μs 0.574ns 2.22ns 0.192 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7.2μs 7.78ns 30.2ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 9.01μs 33.1ns 128ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.58μs 5.15ns 19.9ns 0.721 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 321ns 1.8ns 11ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 402ns 2.07ns 10.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 297ns 0.084ns 0.303ns 0.0433 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.34μs 33.3ns 163ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.94μs 28.9ns 112ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.75μs 6.17ns 23.9ns 0.572 0 0 3.8 KB
#7835 AllCycleSimpleBody net6.0 1.09μs 5.96ns 37.7ns 0 0 0 1.22 KB
#7835 AllCycleSimpleBody netcoreapp3.1 1.39μs 7.19ns 28.8ns 0 0 0 1.2 KB
#7835 AllCycleSimpleBody net472 1.03μs 0.233ns 0.87ns 0.191 0 0 1.23 KB
#7835 AllCycleMoreComplexBody net6.0 7.15μs 3.78ns 14.7ns 0 0 0 4.72 KB
#7835 AllCycleMoreComplexBody netcoreapp3.1 9.08μs 3.15ns 12.2ns 0 0 0 4.62 KB
#7835 AllCycleMoreComplexBody net472 7.76μs 7.91ns 30.6ns 0.734 0 0 4.74 KB
#7835 ObjectExtractorSimpleBody net6.0 322ns 0.0731ns 0.283ns 0 0 0 280 B
#7835 ObjectExtractorSimpleBody netcoreapp3.1 398ns 2.13ns 10.9ns 0 0 0 272 B
#7835 ObjectExtractorSimpleBody net472 300ns 0.0136ns 0.0511ns 0.0446 0 0 281 B
#7835 ObjectExtractorMoreComplexBody net6.0 6.29μs 32.8ns 161ns 0 0 0 3.78 KB
#7835 ObjectExtractorMoreComplexBody netcoreapp3.1 7.77μs 38.1ns 157ns 0 0 0 3.69 KB
#7835 ObjectExtractorMoreComplexBody net472 6.73μs 5.91ns 22.9ns 0.574 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 75.4μs 343ns 1.33μs 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.9μs 220ns 823ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 11.6ns 43.5ns 4.88 0 0 32.51 KB
master EncodeLegacyArgs net6.0 146μs 218ns 844ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 199μs 170ns 659ns 0 0 0 2.15 KB
master EncodeLegacyArgs net472 263μs 23.8ns 92.2ns 0 0 0 2.17 KB
#7835 EncodeArgs net6.0 76.1μs 342ns 1.32μs 0 0 0 32.4 KB
#7835 EncodeArgs netcoreapp3.1 97.5μs 236ns 913ns 0 0 0 32.4 KB
#7835 EncodeArgs net472 109μs 33.9ns 131ns 4.89 0 0 32.51 KB
#7835 EncodeLegacyArgs net6.0 145μs 5.38ns 18.7ns 0 0 0 2.15 KB
#7835 EncodeLegacyArgs netcoreapp3.1 195μs 60.7ns 227ns 0 0 0 2.14 KB
#7835 EncodeLegacyArgs net472 263μs 37.2ns 139ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 393μs 118ns 427ns 0 0 0 4.56 KB
master RunWafRealisticBenchmark netcoreapp3.1 409μs 112ns 404ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 428μs 56.9ns 220ns 0 0 0 4.68 KB
master RunWafRealisticBenchmarkWithAttack net6.0 285μs 48.4ns 187ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 678μs 11.1μs 111μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 310μs 35.7ns 138ns 0 0 0 2.29 KB
#7835 RunWafRealisticBenchmark net6.0 414μs 77.9ns 281ns 0 0 0 4.55 KB
#7835 RunWafRealisticBenchmark netcoreapp3.1 411μs 375ns 1.45μs 0 0 0 4.48 KB
#7835 RunWafRealisticBenchmark net472 428μs 44.3ns 172ns 0 0 0 4.66 KB
#7835 RunWafRealisticBenchmarkWithAttack net6.0 285μs 50.4ns 189ns 0 0 0 2.24 KB
#7835 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 678μs 11.2μs 112μs 0 0 0 2.22 KB
#7835 RunWafRealisticBenchmarkWithAttack net472 311μs 37.3ns 145ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.3μs 127ns 491ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.5μs 317ns 1.55μs 0 0 0 17.42 KB
master SendRequest net472 0.00768ns 0.00289ns 0.0112ns 0 0 0 0 b
#7835 SendRequest net6.0 60.2μs 207ns 878ns 0 0 0 14.52 KB
#7835 SendRequest netcoreapp3.1 70.9μs 238ns 1.04μs 0 0 0 17.42 KB
#7835 SendRequest net472 0.00552ns 0.00167ns 0.00646ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7835

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 48 B 47 B -1 B -2.08%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 7 B 6 B -1 B -14.29%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.91ms 5.91μs 22.1μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.05ms 8.75μs 32.7μs 0 0 0 640 KB
master OriginalCharSlice net472 2.66ms 629ns 2.27μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.41ms 221ns 854ns 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.73ms 245ns 850ns 0 0 0 1 B
master OptimizedCharSlice net472 1.98ms 422ns 1.58μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 822μs 67.2ns 260ns 0 0 0 3 B
master OptimizedCharSliceWithPool netcoreapp3.1 827μs 63.5ns 229ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.14ms 130ns 488ns 0 0 0 48 B
#7835 OriginalCharSlice net6.0 1.99ms 4.4μs 17.1μs 0 0 0 640.01 KB
#7835 OriginalCharSlice netcoreapp3.1 2.07ms 6.27μs 24.3μs 0 0 0 640 KB
#7835 OriginalCharSlice net472 2.64ms 170ns 615ns 100 0 0 641.95 KB
#7835 OptimizedCharSlice net6.0 1.35ms 408ns 1.58μs 0 0 0 6 B
#7835 OptimizedCharSlice netcoreapp3.1 1.66ms 819ns 3.17μs 0 0 0 1 B
#7835 OptimizedCharSlice net472 1.98ms 500ns 1.94μs 0 0 0 73 B
#7835 OptimizedCharSliceWithPool net6.0 853μs 46.5ns 180ns 0 0 0 3 B
#7835 OptimizedCharSliceWithPool netcoreapp3.1 837μs 187ns 726ns 0 0 0 0 b
#7835 OptimizedCharSliceWithPool net472 1.13ms 89.1ns 345ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7835

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.140 697,481.67 795,079.46 bimodal

More allocations ⚠️ in #7835

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.89 KB 42.77 KB 884 B 2.11%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.77 KB 42.52 KB 752 B 1.80%

Fewer allocations 🎉 in #7835

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.32 KB 55.95 KB -376 B -0.67%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 719μs 4.05μs 28.9μs 0 0 0 41.77 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 692μs 3.85μs 24.4μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 895μs 2.42μs 9.05μs 8.33 0 0 56.32 KB
#7835 WriteAndFlushEnrichedTraces net6.0 728μs 3.47μs 14.7μs 0 0 0 42.52 KB
#7835 WriteAndFlushEnrichedTraces netcoreapp3.1 796μs 3.53μs 15.8μs 0 0 0 42.77 KB
#7835 WriteAndFlushEnrichedTraces net472 880μs 2.36μs 8.83μs 8.33 0 0 55.95 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.87μs 9.43ns 43.2ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.62μs 8.37ns 32.4ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.74μs 3.82ns 14.8ns 0.15 0.0137 0 987 B
#7835 ExecuteNonQuery net6.0 1.91μs 1.1ns 4.11ns 0 0 0 1.02 KB
#7835 ExecuteNonQuery netcoreapp3.1 2.68μs 1.43ns 5.56ns 0 0 0 1.02 KB
#7835 ExecuteNonQuery net472 2.78μs 3.15ns 12.2ns 0.154 0.014 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.74μs 7.62ns 29.5ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.23μs 10.9ns 47.5ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.68μs 4.13ns 16ns 0.165 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.75μs 8.79ns 39.3ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.47μs 8.41ns 32.6ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.85μs 3.8ns 14.7ns 0.172 0 0 1.1 KB
#7835 CallElasticsearch net6.0 1.68μs 7.38ns 28.6ns 0 0 0 1.03 KB
#7835 CallElasticsearch netcoreapp3.1 2.16μs 10.5ns 44.7ns 0 0 0 1.03 KB
#7835 CallElasticsearch net472 3.42μs 1.66ns 6.22ns 0.155 0 0 1.04 KB
#7835 CallElasticsearchAsync net6.0 1.84μs 8.92ns 36.8ns 0 0 0 1.01 KB
#7835 CallElasticsearchAsync netcoreapp3.1 2.43μs 1.2ns 4.5ns 0 0 0 1.08 KB
#7835 CallElasticsearchAsync net472 3.7μs 3.34ns 12.9ns 0.166 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.93μs 6.13ns 23.7ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.49μs 9ns 34.9ns 0 0 0 952 B
master ExecuteAsync net472 2.65μs 1.75ns 6.78ns 0.133 0 0 915 B
#7835 ExecuteAsync net6.0 1.85μs 7.08ns 24.5ns 0 0 0 952 B
#7835 ExecuteAsync netcoreapp3.1 2.42μs 9.63ns 37.3ns 0 0 0 952 B
#7835 ExecuteAsync net472 2.54μs 4.12ns 16ns 0.139 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.91μs 20.1ns 75.3ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.64μs 26ns 101ns 0 0 0 2.9 KB
master SendAsync net472 12.1μs 8.02ns 31.1ns 0.483 0 0 3.18 KB
#7835 SendAsync net6.0 6.87μs 6.23ns 24.1ns 0 0 0 2.36 KB
#7835 SendAsync netcoreapp3.1 8.67μs 23.8ns 92.1ns 0 0 0 2.9 KB
#7835 SendAsync net472 12.5μs 7.26ns 27.2ns 0.498 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7835

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 255.46 KB 275.94 KB 20.48 KB 8.02%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.7 KB 44.2 KB 1.5 KB 3.52%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 46.1μs 270ns 2.22μs 0 0 0 43.64 KB
master StringConcatBenchmark netcoreapp3.1 50.1μs 291ns 2.29μs 0 0 0 42.7 KB
master StringConcatBenchmark net472 56.7μs 297ns 1.39μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 490μs 2.3μs 9.22μs 0 0 0 278.04 KB
master StringConcatAspectBenchmark netcoreapp3.1 506μs 2.28μs 8.54μs 0 0 0 255.46 KB
master StringConcatAspectBenchmark net472 410μs 2.31μs 15μs 0 0 0 278.53 KB
#7835 StringConcatBenchmark net6.0 46.8μs 210ns 756ns 0 0 0 43.51 KB
#7835 StringConcatBenchmark netcoreapp3.1 49.3μs 245ns 2.22μs 0 0 0 44.2 KB
#7835 StringConcatBenchmark net472 56.6μs 139ns 520ns 0 0 0 57.34 KB
#7835 StringConcatAspectBenchmark net6.0 460μs 888ns 3.08μs 0 0 0 276.99 KB
#7835 StringConcatAspectBenchmark netcoreapp3.1 542μs 2.58μs 9.99μs 0 0 0 275.94 KB
#7835 StringConcatAspectBenchmark net472 414μs 2.33μs 15.3μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.59μs 14.1ns 68.9ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.65μs 14.7ns 56.9ns 0 0 0 1.7 KB
master EnrichedLog net472 4.19μs 3.84ns 14.9ns 0.248 0 0 1.64 KB
#7835 EnrichedLog net6.0 2.59μs 14ns 72.7ns 0 0 0 1.7 KB
#7835 EnrichedLog netcoreapp3.1 3.67μs 14.2ns 54.9ns 0 0 0 1.7 KB
#7835 EnrichedLog net472 3.98μs 3.96ns 14.8ns 0.258 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 55.1ns 199ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 129μs 208ns 807ns 0 0 0 4.31 KB
master EnrichedLog net472 169μs 296ns 1.14μs 0 0 0 4.52 KB
#7835 EnrichedLog net6.0 123μs 66ns 247ns 0 0 0 4.31 KB
#7835 EnrichedLog netcoreapp3.1 128μs 198ns 741ns 0 0 0 4.31 KB
#7835 EnrichedLog net472 169μs 52.2ns 195ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.16μs 21.6ns 80.7ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.77μs 15.2ns 58.7ns 0 0 0 2.26 KB
master EnrichedLog net472 7.55μs 7.72ns 29.9ns 0.301 0 0 2.08 KB
#7835 EnrichedLog net6.0 5.15μs 25.3ns 101ns 0 0 0 2.26 KB
#7835 EnrichedLog netcoreapp3.1 6.79μs 6.44ns 23.2ns 0 0 0 2.26 KB
#7835 EnrichedLog net472 7.61μs 9.36ns 36.3ns 0.305 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.93μs 9.28ns 35.9ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.61μs 4.31ns 16.7ns 0 0 0 1.2 KB
master SendReceive net472 3.11μs 1.28ns 4.62ns 0.185 0 0 1.2 KB
#7835 SendReceive net6.0 2.02μs 8.09ns 31.3ns 0 0 0 1.2 KB
#7835 SendReceive netcoreapp3.1 2.65μs 12.1ns 47ns 0 0 0 1.2 KB
#7835 SendReceive net472 3.02μs 3.76ns 14.5ns 0.181 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.33μs 10.9ns 42.3ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.75μs 8.04ns 30.1ns 0 0 0 1.63 KB
master EnrichedLog net472 6.96μs 6.28ns 24.3ns 0.313 0 0 2.03 KB
#7835 EnrichedLog net6.0 4.26μs 3.75ns 14.5ns 0 0 0 1.58 KB
#7835 EnrichedLog netcoreapp3.1 5.74μs 8.24ns 31.9ns 0 0 0 1.63 KB
#7835 EnrichedLog net472 6.87μs 4.45ns 16.6ns 0.31 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 786ns 3.71ns 14.4ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 1.01μs 4.75ns 18.4ns 0 0 0 576 B
master StartFinishSpan net472 943ns 0.246ns 0.92ns 0.09 0 0 578 B
master StartFinishScope net6.0 906ns 4.96ns 30.6ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.19μs 6.13ns 31.8ns 0 0 0 697 B
master StartFinishScope net472 1.16μs 0.86ns 3.33ns 0.104 0 0 658 B
#7835 StartFinishSpan net6.0 775ns 3.83ns 15.8ns 0 0 0 576 B
#7835 StartFinishSpan netcoreapp3.1 965ns 5.26ns 30.7ns 0 0 0 576 B
#7835 StartFinishSpan net472 952ns 0.275ns 0.993ns 0.0905 0 0 578 B
#7835 StartFinishScope net6.0 920ns 4.76ns 23.3ns 0 0 0 696 B
#7835 StartFinishScope netcoreapp3.1 1.17μs 6.34ns 33.5ns 0 0 0 696 B
#7835 StartFinishScope net472 1.11μs 0.172ns 0.664ns 0.0999 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.06μs 5.65ns 28.2ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.47μs 6.59ns 23.8ns 0 0 0 696 B
master RunOnMethodBegin net472 1.46μs 0.443ns 1.6ns 0.102 0 0 658 B
#7835 RunOnMethodBegin net6.0 1.1μs 0.487ns 1.89ns 0 0 0 696 B
#7835 RunOnMethodBegin netcoreapp3.1 1.41μs 6.71ns 26ns 0 0 0 696 B
#7835 RunOnMethodBegin net472 1.46μs 0.314ns 1.22ns 0.102 0 0 658 B

@datadog-official

This comment has been minimized.

Sign in to view
@rithikanarayan rithikanarayan marked this pull request as ready for review November 19, 2025 21:50
@rithikanarayan rithikanarayan requested review from a team as code owners November 19, 2025 21:50
@lucaspimentel
Copy link
Member

lucaspimentel commented Nov 19, 2025

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Nov 19, 2025

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

This comment was marked as outdated.

Sign in to view
@rithikanarayan rithikanarayan force-pushed the rithika.narayan/adding-request-id-headers branch from 8a247db to b5116dd Compare November 21, 2025 17:58
@rithikanarayan @lucaspimentel
remove null check
b6a25b2 
Co-authored-by: Lucas Pimentel <lucas.pimentel@datadoghq.com>
lucaspimentel
lucaspimentel approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@lucaspimentel lucaspimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add some non-blocking comments for things we can clean up later in a separate PR.

lucaspimentel
lucaspimentel reviewed Nov 21, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/LambdaRequestBuilder.cs
Comment on lines +44 to +47
if (state != null)
{
request.Headers.Set("lambda-runtime-aws-request-id", (string)state);
}
Copy link
Member

@lucaspimentel lucaspimentel Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it should never happen, if state is ever a different type from string, this casting operation will throw an exception. It would be safer to check that state is a string, not simply not null

The more modern way of doing this in C# is by combining the type check with a string variable declaration and removing the (string) casting operator:

if (state is string requestId)
{
    request.Headers.Set("lambda-runtime-aws-request-id", requestId);
}

lucaspimentel
lucaspimentel reviewed Nov 21, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/LambdaCommon.cs
}

internal static void SendEndInvocation(ILambdaExtensionRequest requestBuilder, Scope scope, bool isError, string data)
internal static void SendEndInvocation(ILambdaExtensionRequest requestBuilder, Scope scope, object state, bool isError, string data)
Copy link
Member

@lucaspimentel lucaspimentel Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we should try to avoid using the object type when passing arguments around. C# developers like the strong type safety that the language provides and treating anything as object disable that language feature.

To avoid that, we should cast the state to CallTargetState as early as possible and pass it around as a CallTargetState, not as object.

lucaspimentel
lucaspimentel reviewed Nov 21, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/LambdaCommon.cs
var request = requestBuilder.GetStartInvocationRequest();
WriteRequestPayload(request, data);
WriteRequestHeaders(request, context);
WriteRequestHeaders(request, context?.ClientContext?.Custom);
Copy link
Member

@lucaspimentel lucaspimentel Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If either context or context.ClientContext or context.ClientContext.Custom are null, we will effectively call WriteRequestHeaders(request, null).

Does WriteRequestHeaders() handle null gracefully? Or should we check for null before calling?

if (context?.ClientContext?.Custom is { } c)
{
    WriteRequestHeaders(request, c);
}

Copy link
Contributor Author

@rithikanarayan rithikanarayan Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WriteRequestHeaders starts by checking if context is null (if it is null it does nothing). This was how it was structured prior to my changes, so I am choosing to leave it that way.

lucaspimentel
lucaspimentel reviewed Nov 21, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/LambdaRequestBuilder.cs
}

WebRequest ILambdaExtensionRequest.GetEndInvocationRequest(Scope scope, bool isError)
WebRequest ILambdaExtensionRequest.GetEndInvocationRequest(Scope scope, object state, bool isError)
Copy link
Member

@lucaspimentel lucaspimentel Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a good example of why not to not use object in method signature if we can avoid it: in some methods state is a CallTargetState, but here it's a string. It's easy to get them confused and try to cast to the wrong type, which will throw an exception at run time.

Or if someone mistakenly checks if (state is CallTargetState) before casting, it will always be false (because this one is a string) and we'll never hit the code path below that adds the request header.

@rithikanarayan rithikanarayan merged commit 5738b43 into master Nov 21, 2025
153 checks passed
@rithikanarayan rithikanarayan deleted the rithika.narayan/adding-request-id-headers branch November 21, 2025 21:23
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 21, 2025
@lucaspimentel lucaspimentel changed the title Add request-id as header to lambda start/end invocation [AWS Lambda] Add request-id as header to Lambda start/end invocation Nov 21, 2025
lucaspimentel
lucaspimentel reviewed Nov 21, 2025
View reviewed changes
...adog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/HandlerWrapperSetHandlerIntegration.cs
LambdaCommon.Log("DelegateWrapper Running OnDelegateBegin");

Scope scope;
object requestid = null;
Copy link
Member

@lucaspimentel lucaspimentel Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[naming conventions]
We should use requestId instead of requestid (this is the nit-pickiest comment in this PR, I promise)

[type safety]
requestid can be string since ILambdaContext.AwsRequestId is declared as string. We want to avoid using object as much as possible.

lucaspimentel
lucaspimentel reviewed Nov 21, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/LambdaCommon.cs
}

internal static async Task EndInvocationAsync(string returnValue, Exception exception, Scope scope, ILambdaExtensionRequest requestBuilder)
internal static async Task EndInvocationAsync(string returnValue, Exception exception, object stateObject, ILambdaExtensionRequest requestBuilder)
Copy link
Member

@lucaspimentel lucaspimentel Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about the using object as parameter type.

lucaspimentel
lucaspimentel reviewed Nov 21, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/Lambda/LambdaCommon.cs
internal static async Task EndInvocationAsync(string returnValue, Exception exception, Scope scope, ILambdaExtensionRequest requestBuilder)
internal static async Task EndInvocationAsync(string returnValue, Exception exception, object stateObject, ILambdaExtensionRequest requestBuilder)
{
var state = (CallTargetState)stateObject!;
Copy link
Member

@lucaspimentel lucaspimentel Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dangerous cast that will throw an exception if stateObject is null or otherwise not a CallTargetState. Since stateObject is declared as object, it could be anything, so we should always be defensive and check first:

if (state is CallTargetState)
{
    ...

Even better would be to use CallTargetState as the parameter type instead of object. Then the type is guaranteed and we won't need to either check or cast here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@duncanista duncanista duncanista approved these changes

Assignees

No one assigned

Labels

area:integrations area:serverless

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

4 participants

@rithikanarayan @lucaspimentel @duncanista