Add process tags to dynamic instrumentation snapshots #7839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandonr
changed the title
This comment has been minimized.
This comment has been minimized.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7839) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (76ms) : 70, 82
master - mean (76ms) : 69, 84
section Bailout
This PR (7839) - mean (80ms) : 73, 86
master - mean (81ms) : 73, 88
section CallTarget+Inlining+NGEN
This PR (7839) - mean (1,129ms) : 1051, 1207
master - mean (1,132ms) : 1047, 1218
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (120ms) : 111, 128
master - mean (119ms) : 110, 127
section Bailout
This PR (7839) - mean (121ms) : 115, 127
master - mean (120ms) : 112, 128
section CallTarget+Inlining+NGEN
This PR (7839) - mean (804ms) : 762, 845
master - mean (812ms) : 776, 848
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (107ms) : 99, 114
master - mean (106ms) : 99, 114
section Bailout
This PR (7839) - mean (107ms) : 101, 112
master - mean (107ms) : 100, 115
section CallTarget+Inlining+NGEN
This PR (7839) - mean (762ms) : 714, 811
master - mean (758ms) : 716, 800
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (105ms) : 99, 111
master - mean (105ms) : 96, 113
section Bailout
This PR (7839) - mean (106ms) : 100, 111
master - mean (105ms) : 99, 112
section CallTarget+Inlining+NGEN
This PR (7839) - mean (723ms) : 695, 751
master - mean (727ms) : 699, 756
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (195ms) : 191, 199
master - mean (195ms) : 190, 200
section Bailout
This PR (7839) - mean (198ms) : 193, 203
master - mean (198ms) : 195, 200
section CallTarget+Inlining+NGEN
This PR (7839) - mean (1,189ms) : 1100, 1278
master - mean (1,172ms) : 1112, 1232
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (278ms) : 272, 284
master - mean (280ms) : 275, 285
section Bailout
This PR (7839) - mean (278ms) : 275, 282
master - mean (281ms) : 275, 287
section CallTarget+Inlining+NGEN
This PR (7839) - mean (945ms) : 899, 990
master - mean (947ms) : 901, 993
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (275ms) : 264, 285
master - mean (272ms) : 267, 278
section Bailout
This PR (7839) - mean (271ms) : 267, 275
master - mean (273ms) : 269, 276
section CallTarget+Inlining+NGEN
This PR (7839) - mean (937ms) : 888, 986
master - mean (938ms) : 889, 987
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7839) - mean (270ms) : 265, 274
master - mean (269ms) : 264, 275
section Bailout
This PR (7839) - mean (273ms) : 266, 279
master - mean (269ms) : 266, 272
section CallTarget+Inlining+NGEN
This PR (7839) - mean (862ms) : 840, 885
master - mean (859ms) : 831, 886
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
add a process tags field next to where the service name is added in the snapshot json.
dotnet version of DataDog/dd-trace-java#8779
Reason for change
AIDM-195
Implementation details
I wanted to inject the setting from
dd-trace-dotnet/tracer/src/Datadog.Trace/Debugger/DebuggerFactory.cs
Line 30 in 79b266b
Another option was to put it in the debugger settings, but it felt out of place as those settings are specific to the live debugger, not a repeat of global tracer settings.
In the end I decided to inject a little bit so that I could specify the value in tests.
Test coverage
just made sure the test that checks json correctness includes this
Other details