Add process tags to remote config #7840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7840) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (75ms) : 70, 81
master - mean (75ms) : 71, 79
section Bailout
This PR (7840) - mean (80ms) : 75, 85
master - mean (80ms) : 74, 85
section CallTarget+Inlining+NGEN
This PR (7840) - mean (1,128ms) : 1050, 1205
master - mean (1,125ms) : 1060, 1190
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (117ms) : 109, 125
master - mean (119ms) : 111, 127
section Bailout
This PR (7840) - mean (120ms) : 112, 128
master - mean (120ms) : 113, 127
section CallTarget+Inlining+NGEN
This PR (7840) - mean (801ms) : 767, 835
master - mean (813ms) : 781, 845
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (105ms) : 98, 113
master - mean (107ms) : 100, 114
section Bailout
This PR (7840) - mean (106ms) : 100, 112
master - mean (107ms) : 103, 112
section CallTarget+Inlining+NGEN
This PR (7840) - mean (743ms) : 707, 779
master - mean (770ms) : 737, 803
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (103ms) : 97, 110
master - mean (105ms) : 99, 111
section Bailout
This PR (7840) - mean (105ms) : 100, 111
master - mean (106ms) : 101, 111
section CallTarget+Inlining+NGEN
This PR (7840) - mean (714ms) : 678, 750
master - mean (731ms) : 703, 760
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (193ms) : 188, 198
master - mean (193ms) : 188, 198
section Bailout
This PR (7840) - mean (196ms) : 194, 198
master - mean (197ms) : 193, 201
section CallTarget+Inlining+NGEN
This PR (7840) - mean (1,172ms) : 1114, 1229
master - mean (1,186ms) : 1098, 1275
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (278ms) : 274, 282
master - mean (277ms) : 271, 284
section Bailout
This PR (7840) - mean (283ms) : 273, 292
master - mean (277ms) : 273, 281
section CallTarget+Inlining+NGEN
This PR (7840) - mean (946ms) : 901, 990
master - mean (950ms) : 901, 999
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (274ms) : 261, 287
master - mean (270ms) : 265, 276
section Bailout
This PR (7840) - mean (272ms) : 265, 279
master - mean (271ms) : 265, 277
section CallTarget+Inlining+NGEN
This PR (7840) - mean (943ms) : 892, 994
master - mean (930ms) : 882, 978
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7840) - mean (274ms) : 266, 282
master - mean (269ms) : 263, 275
section Bailout
This PR (7840) - mean (273ms) : 265, 282
master - mean (269ms) : 264, 274
section CallTarget+Inlining+NGEN
This PR (7840) - mean (855ms) : 830, 879
master - mean (856ms) : 835, 877
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
reviewed
Nov 18, 2025
Member
andrewlock
left a comment
andrewlock
left a comment
There was a problem hiding this comment.
I didn't see any existing tests on the content of the requests, didn't really feel like adding some.
Will this be covered by system-tests? Historically we've broken RCM and not known about it, so I'm hesitant to just ok this as-is.
At the very least, we should manually test this against a real agent, to ensure the generated JSON is valid. And ideally then add some snapshots for the response to make sure it doesn't drift accidentally
Contributor
Author
yes it should be, though I have not enabled them yet because it's made as all-or-nothing for process tags. I'll double check.
We do have some tests with sample responses, in https://github.com/DataDog/dd-trace-dotnet/blob/20246d2febfbbc43aad6598e9ddebfbb36d89aa2/tracer/test/Datadog.Trace.Tests/RemoteConfigurationManagement/RcmResponses.cs, but here I modify the request, so I can create snapshots of requests, but it'd be kinda self-asserting |
vandonr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
adding process tags next to the service name in remote config requests
equivalent Java PR: DataDog/dd-trace-java#8705
related change on the agent side: DataDog/datadog-agent#36049
Reason for change
AIDM-195
Implementation details
Test coverage
I didn't see any existing tests on the content of the requests, didn't really feel like adding some.
Other details