[Dynamic Instrumentation] DEBUG-4689 Remove the 100-probe limit for Dynamic Instrumentation #7848
+36
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7848) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (77ms) : 71, 83
master - mean (77ms) : 70, 83
section Bailout
This PR (7848) - mean (82ms) : 76, 88
master - mean (80ms) : 74, 87
section CallTarget+Inlining+NGEN
This PR (7848) - mean (1,141ms) : 1056, 1225
master - mean (1,133ms) : 1068, 1198
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (120ms) : 111, 130
master - mean (119ms) : 111, 126
section Bailout
This PR (7848) - mean (120ms) : 112, 129
master - mean (120ms) : 111, 129
section CallTarget+Inlining+NGEN
This PR (7848) - mean (808ms) : 771, 845
master - mean (809ms) : 764, 853
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (106ms) : 97, 115
master - mean (106ms) : 96, 116
section Bailout
This PR (7848) - mean (107ms) : 100, 113
master - mean (108ms) : 99, 117
section CallTarget+Inlining+NGEN
This PR (7848) - mean (758ms) : 721, 796
master - mean (768ms) : 722, 814
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (106ms) : 99, 114
master - mean (106ms) : 97, 115
section Bailout
This PR (7848) - mean (107ms) : 97, 117
master - mean (106ms) : 99, 113
section CallTarget+Inlining+NGEN
This PR (7848) - mean (719ms) : 684, 755
master - mean (733ms) : 698, 768
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (193ms) : 189, 198
master - mean (195ms) : 190, 200
section Bailout
This PR (7848) - mean (197ms) : 194, 200
master - mean (199ms) : 194, 203
section CallTarget+Inlining+NGEN
This PR (7848) - mean (1,168ms) : 1120, 1215
master - mean (1,184ms) : 1116, 1253
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (279ms) : 272, 285
master - mean (278ms) : 273, 283
section Bailout
This PR (7848) - mean (278ms) : 274, 283
master - mean (279ms) : 273, 284
section CallTarget+Inlining+NGEN
This PR (7848) - mean (953ms) : 911, 995
master - mean (944ms) : 901, 986
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (270ms) : 265, 275
master - mean (271ms) : 266, 276
section Bailout
This PR (7848) - mean (271ms) : 266, 276
master - mean (272ms) : 267, 277
section CallTarget+Inlining+NGEN
This PR (7848) - mean (931ms) : 885, 977
master - mean (933ms) : 883, 983
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7848) - mean (270ms) : 265, 274
master - mean (269ms) : 264, 275
section Bailout
This PR (7848) - mean (271ms) : 266, 276
master - mean (269ms) : 265, 274
section CallTarget+Inlining+NGEN
This PR (7848) - mean (853ms) : 835, 871
master - mean (860ms) : 841, 880
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove the hard-coded 100-probe limit per ptobe type for Dynamic Instrumentation and replace it with an internal, configurable per-type limit that defaults to “no limit”.
Reason for change
The MCP server and agentic debugging use cases are becoming increasingly popular. This growth is expected to lead to hitting the 100 probe limit in services more frequently.