Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/govulncheck: fix and simplify the bash script #1623

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

Julio-Guerra
Copy link
Contributor

What does this PR do?

Avoid bash script problem (especially due to the previous echo $results | wc -l always returning 1.

Motivation

The bash script is always failing due to a mistake. To avoid it and make this CI more useful, we instead let govulncheck report its exit code along with its detailed output to make this workflow directly usable.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

The bash script is always failing due to a mistake. To avoid it and make this CI more useful, we instead let govulncheck report its exit code along with its detailed output to make this workflow directly usable.
@Julio-Guerra Julio-Guerra added this to the v1.46.0 milestone Dec 14, 2022
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner December 14, 2022 22:23
@pr-commenter
Copy link

pr-commenter bot commented Dec 14, 2022

Benchmarks

Comparing candidate commit 324db9e in PR branch julio.guerra/govulncheck-ci-fix-script with baseline commit a2b9399 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@Julio-Guerra Julio-Guerra merged commit a694524 into main Dec 14, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/govulncheck-ci-fix-script branch December 14, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants