Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/remoteconfig: client error handling (backport of release-v1.45.x fixes) #1627

Merged
merged 5 commits into from
Dec 28, 2022
Merged

internal/remoteconfig: client error handling (backport of release-v1.45.x fixes) #1627

merged 5 commits into from
Dec 28, 2022

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Dec 16, 2022 •
edited
Loading

What does this PR do?

Properly handle many error cases that were not in the remote config client.
Especially the "no remote config update" case {} that is leading to a json parsing error in the repository Update().
Backport of release-v1.45.x changes

Motivation

We are experiencing "unexpected end of JSON input" errors in staging and prod, since v1.44.0.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@Julio-Guerra Julio-Guerra added this to the v1.46.0 milestone Dec 16, 2022
@Julio-Guerra Julio-Guerra changed the title Julio.guerra/fix rc client Fix rc client errors management Dec 16, 2022
@pr-commenter
Copy link

pr-commenter bot commented Dec 16, 2022 •
edited
Loading

Benchmarks

Comparing candidate commit 21b8cfb in PR branch julio.guerra/fix-rc-client with baseline commit 2d25957 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@Julio-Guerra Julio-Guerra changed the title Fix rc client errors management Fix rc client error handling Dec 16, 2022
@Julio-Guerra Julio-Guerra changed the title Fix rc client error handling internal/remoteconfig: client error handling Dec 16, 2022
@Julio-Guerra Julio-Guerra marked this pull request as ready for review December 16, 2022 16:47
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner December 16, 2022 16:47
@Julio-Guerra Julio-Guerra requested a review from a team December 16, 2022 16:47
@Julio-Guerra Julio-Guerra changed the title internal/remoteconfig: client error handling internal/remoteconfig: client error handling (backport of release-v1.45.x fixes) Dec 16, 2022
@nsrip-dd nsrip-dd merged commit f7a009a into main Dec 28, 2022
@nsrip-dd nsrip-dd deleted the julio.guerra/fix-rc-client branch December 28, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hellzy Hellzy Hellzy approved these changes

@dianashevchenko dianashevchenko dianashevchenko approved these changes

Assignees
No one assigned
Labels
remote-config
Projects
None yet
Milestone
v1.46.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Julio-Guerra @Hellzy @dianashevchenko @nsrip-dd