Fix: Support custom propagators in startup log #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-10-18 15:15:44 Comparing candidate commit e0e305c in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics. scenario:BenchmarkInjectW3C-24
|
rarguelloF
approved these changes
Oct 17, 2024
darccio
approved these changes
Oct 18, 2024
ddtrace/tracer/log_test.go
Outdated
| var stop func() | ||
| if customProp != nil { | ||
| tracer, _, _, stop = startTestTracer(t, WithLogger(tp), WithPropagator(customProp)) | ||
| // tracer = newTracer(WithLogger(tp), WithPropagator(customProp)) |
There was a problem hiding this comment.
nit: is this comment relevant?
The same for its sibling below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modifies the logic within the startup log for determining values for propagation injectors and extractors.
Fixes #2923
Motivation
The previous logic expected to cast the current propagator to a *chainedPropagator, but that's not always viable, especially in the case that a custom propagator has been registered on the tracer via the WithPropagator StartOption.
Reviewer's Checklist
Unsure? Have a question? Request a review!